After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689033 - symbol-db: When updating a symbol try to update the closest one.
symbol-db: When updating a symbol try to update the closest one.
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: symbol-db
unspecified
Other All
: Normal normal
: ---
Assigned To: Massimo Cora'
Anjuta maintainers
: 690314 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-25 16:30 UTC by Carl-Anton Ingmarsson
Modified: 2012-12-23 10:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
symbol-db: When updating a symbol try to update the closest one. (3.54 KB, patch)
2012-11-25 16:30 UTC, Carl-Anton Ingmarsson 		committed Details | Review
symbol-db: rename sdb_engine_get_tuple_id_by_unique_name4()... (3.35 KB, patch)
2012-12-22 22:20 UTC, Carl-Anton Ingmarsson 		none Details | Review

Description Carl-Anton Ingmarsson 2012-11-25 16:30:02 UTC 
See the attached patch.
Comment 1 Carl-Anton Ingmarsson 2012-11-25 16:30:04 UTC 
Created attachment 229826 [details] [review]
symbol-db: When updating a symbol try to update the closest one.

This way we get rid of alot of warnings like this:
(lt-anjuta:27226): libanjuta-symbol-db-WARNING **: SQL execute_non_select failed: columns name, file_defined_id, file_position are not unique

which was caused by updating two symbols that has the same name but is at different file positions.
Previously it could happen that we updated the first symbol with the file position of the second
which caused the unique constraint to fail.
Comment 2 Sébastien Granjoux 2012-12-20 20:17:43 UTC 
*** Bug 690314 has been marked as a duplicate of this bug. ***
Comment 3 Massimo Cora' 2012-12-22 16:14:53 UTC 
Comment on attachment 229826 [details] [review]
symbol-db: When updating a symbol try to update the closest one.

I've committed the patch. Can you please rename the function sdb_engine_get_tuple_id_by_unique_name4 to sdb_engine_get_tuple_id_by_unique_name5 so that it reflects that it's taking 5 key-value parameters? Thanks
Comment 4 Carl-Anton Ingmarsson 2012-12-22 22:20:44 UTC 
Created attachment 232135 [details] [review]
symbol-db: rename sdb_engine_get_tuple_id_by_unique_name4()...

to sdb_engine_get_tuple_id_by_unique_name5() since it now takes five parameters.
Comment 5 Massimo Cora' 2012-12-23 10:45:37 UTC 
thanks, patch applied.
I'm closing the bug.