After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688988 - [PATCH] add more protocolname<->displayname
[PATCH] add more protocolname<->displayname
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 689074
 
 
Reported: 2012-11-24 18:46 UTC by Gabriele Giacone
Modified: 2012-11-26 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add some protocolname-displayname (552 bytes, patch)
2012-11-24 19:01 UTC, Gabriele Giacone
committed Details | Review

Description Gabriele Giacone 2012-11-24 18:46:02 UTC
Please apply attached patch, it adds some associations protocol<->displayname to make all protocol names more human readable, uppercase.

BTW real developers on #telepathy made me notice ideal would be using EnglishName in TpProtocol object and removing empathy_protocol_name_to_display_name function completely, instead of hardcoding names.

Thanks for considering.
Comment 1 Gabriele Giacone 2012-11-24 19:01:30 UTC
Created attachment 229782 [details] [review]
add some protocolname-displayname
Comment 2 Guillaume Desmottes 2012-11-26 10:57:05 UTC
Thanks for the patch. I merged it to master.

Attachment 229782 [details] pushed as 45eadc1 - add some protocolname-displayname
Comment 3 Guillaume Desmottes 2012-11-26 10:58:24 UTC
(In reply to comment #0)
> BTW real developers on #telepathy made me notice ideal would be using
> EnglishName in TpProtocol object and removing
> empathy_protocol_name_to_display_name function completely, instead of
> hardcoding names.

That's a good point. I opened bug #689074 about this.