After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688969 - Only support Webkit2
Only support Webkit2
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-24 07:31 UTC by Thomas Bechtold
Modified: 2013-04-14 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove-WebKit-1-support (20.94 KB, patch)
2013-02-06 17:18 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Rebased patch (20.46 KB, patch)
2013-03-31 12:02 UTC, Carlos Garcia Campos 		committed Details | Review

Description Thomas Bechtold 2012-11-24 07:31:11 UTC 
Devhelp currently supports Webkit 1 & 2. To simplify the code, IMHO it would be nice to drop Webkit 1 support.
Comment 1 Carlos Garcia Campos 2012-11-24 11:57:46 UTC 
WebKit2 API is not "stable" yet, to make the transition easier, the idea was to add a compile option during this development cycle, and remove the webkit1 support for the next cycle. In any case, I'm fine with removing the webkit1 code, the API used by devhelp won't probably change, and there aren't regressions (well, maybe the print preview, but I bet nobody will notice and it's not clear it will be implemented in time for WebKitGTK+ 2.0)
Comment 2 Javier Jardón (IRC: jjardon) 2013-02-06 17:18:59 UTC 
Created attachment 235317 [details] [review]
Remove-WebKit-1-support
Comment 3 Frederic Peters 2013-02-06 17:23:48 UTC 
As Carlos wrote, I'd keep webkit 1 support for 3.8.
Comment 4 Carlos Garcia Campos 2013-03-31 12:02:54 UTC 
Created attachment 240196 [details] [review]
Rebased patch

I've rebased the patch and also bumped requirements to 2.0. This could be applied as soon as we branch for 3.8.
Comment 5 Aleksander Morgado 2013-04-08 13:45:30 UTC 
Comment on attachment 240196 [details] [review]
Rebased patch

Just branched a gnome-3-8, so feel free to apply it in git master.
Comment 6 Carlos Garcia Campos 2013-04-14 12:50:58 UTC 
Comment on attachment 240196 [details] [review]
Rebased patch

Pushed.