After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688935 - rtpjitterbuffer not always correctly warns about resetting skew
rtpjitterbuffer not always correctly warns about resetting skew
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal minor
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-23 13:54 UTC by Markovtsev Vadim
Modified: 2013-02-07 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Markovtsev Vadim 2012-11-23 13:54:16 UTC 
gst/rtpmanager/rtpjitterbuffer.c, near line 457:

  if (ABS (delta - jbuf->skew) > GST_SECOND) {
    GST_WARNING ("delta - skew: %" GST_TIME_FORMAT " too big, reset skew",
        GST_TIME_ARGS (delta - jbuf->skew));
    rtp_jitter_buffer_resync (jbuf, time, gstrtptime, ext_rtptime, TRUE);
    send_diff = 0;
    delta = 0;
  }

If (delta - jbuf->skew) < 0, the warning will print the negative time (a really big number). In my case, this actually happens. I suggest to add ABS:

GST_WARNING ("delta - skew: %" GST_TIME_FORMAT " too big, reset skew",
        GST_TIME_ARGS (ABS (delta - jbuf->skew)));
Comment 1 Wim Taymans 2013-02-07 13:34:36 UTC 
commit ed6dfd55bb93d28fb608543deffef696c1e7b4a0
Author: Markovtsev Vadim <v.markovtsev at samsung.com>
Date:   Thu Feb 7 14:32:26 2013 +0100

    rtpjitterbuffer: improve debug output
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=688935