GNOME Bugzilla – Bug 688931
GMemoryOutputStream: Add new _resizable() constructor usable from bindings
Last modified: 2012-11-28 01:51:28 UTC
Really, the memory output stream API is too warped around the model where it's a fixed size buffer that you've already allocated. Even in C, I find myself always wanting to use it to just accumulate data into an arbitrary-sized buffer it allocates. Unfortunately, it's also not usable from bindings because it's not common to bind g_free() and g_realloc(), but if you just pass NULL, you get the default of a fixed size, which is useless as per above. I am going to use this from a gjs test case, and the GSubprocess test cases also will use it.
Created attachment 229721 [details] [review] GMemoryOutputStream: Add new _resizable() constructor usable from bindings
Comment on attachment 229721 [details] [review] GMemoryOutputStream: Add new _resizable() constructor usable from bindings makes sense to me
(In reply to comment #2) > (From update of attachment 229721 [details] [review]) > makes sense to me Procedural question: You tagged this 'reviewed', but no comments; does that mean 'accepted-commit-now'? Or waiting for a +1 from another GLib hacker?
It means you get to decide what it means. I didn't want to a-c-n a patch in code that I don't know that well that was posted on a holiday, such that some people might not even have seen the bug yet.
even though it is another example of 1-line-wrapper around existing api, the bindings argument makes sense
Attachment 229721 [details] pushed as ed5c17e - GMemoryOutputStream: Add new _resizable() constructor usable from bindings