After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688886 - Improve the i18n documentation
Improve the i18n documentation
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
2.35.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-11-22 19:04 UTC by Sébastien Wilmet
Modified: 2012-11-22 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve i18n documentation (1.81 KB, patch)
2012-11-22 19:06 UTC, Sébastien Wilmet 		reviewed Details | Review

Description Sébastien Wilmet 2012-11-22 19:04:39 UTC 
The documentation doesn't explain clearly which gettext functions must be called for an application or a library.

I'll attach a patch.
Comment 1 Sébastien Wilmet 2012-11-22 19:06:12 UTC 
Created attachment 229653 [details] [review]
Improve i18n documentation

Clearly explain which gettext functions must be called. It depends
whether the program is an application or a library.
Comment 2 Emmanuele Bassi (:ebassi) 2012-11-22 21:37:43 UTC 
Review of attachment 229653 [details] [review]:

looks okay to me.

::: glib/ggettext.c
@@ +486,3 @@
+ * For a library, you only have to call bindtextdomain() and
+ * bind_textdomain_codeset() in your initialization function. If your library
+ * doesn't have an initialization function, call the functions lazily before the

I'd use "you can call the function before the first translated message" instead.
Comment 3 Sébastien Wilmet 2012-11-22 22:10:59 UTC 
OK, thank you for the review. I've fixed and pushed the commit.