After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688878 - Notified about impossible action
Notified about impossible action
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-22 16:27 UTC by Bastien Nocera
Modified: 2012-11-29 22:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shot (15.69 KB, image/png)
2012-11-22 16:30 UTC, Bastien Nocera
  Details
power: Check if action is available before taking action (5.27 KB, patch)
2012-11-29 22:16 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2012-11-22 16:27:03 UTC
Hibernation is not available on my machine (swap size < RAM size)
This is shown correctly in the Power panel (grayed out option)

If Hibernation is selected for "critically low battery" (it is the default after all), g-s-d will warn that it will soon hibernate, which it cannot.

It should automatically fallback to suspending, or simply warning that everything will soon be lost and shutdown the machine in this case.
Comment 1 Bastien Nocera 2012-11-22 16:30:11 UTC
Created attachment 229643 [details]
shot
Comment 2 Bastien Nocera 2012-11-29 22:16:18 UTC
Created attachment 230243 [details] [review]
power: Check if action is available before taking action

Don't show a "About to hibernate" warning when we know the machine
cannot suspend, by taking into account the availability of the
requested action type before taking action.
Comment 3 Bastien Nocera 2012-11-29 22:17:09 UTC
Attachment 230243 [details] pushed as ff91a24 - power: Check if action is available before taking action