After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688806 - build: Ensure pkglibdir exists
build: Ensure pkglibdir exists
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-21 13:40 UTC by Colin Walters
Modified: 2012-11-28 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Ensure pkglibdir exists (887 bytes, patch)
2012-11-21 13:40 UTC, Colin Walters 		reviewed Details | Review
build: Ensure pkglibdir exists (887 bytes, patch)
2012-11-28 13:50 UTC, Colin Walters 		none Details | Review

Description Colin Walters 2012-11-21 13:40:05 UTC 
Recent automake versions switched to not creating empty directories,
but at the moment NetworkManager g_warning()s on startup if it doesn't
find $(pkglibdir).  So let's make it.
Comment 1 Colin Walters 2012-11-21 13:40:08 UTC 
Created attachment 229573 [details] [review]
build: Ensure pkglibdir exists
Comment 2 Dan Winship 2012-11-26 16:50:44 UTC 
Comment on attachment 229573 [details] [review]
build: Ensure pkglibdir exists

ok
Comment 3 Dan Winship 2012-11-26 16:51:50 UTC 
Comment on attachment 229573 [details] [review]
build: Ensure pkglibdir exists

>+	$(mkinstalldirs) -m 0700 $(DESTDIR)$(pkglibdir)

actually, shouldn't it be 755 for pkglibdir?
Comment 4 Colin Walters 2012-11-28 13:50:34 UTC 
Created attachment 230087 [details] [review]
build: Ensure pkglibdir exists

Recent automake versions switched to not creating empty directories,
but at the moment NetworkManager g_warning()s on startup if it doesn't
find $(pkglibdir).  So let's make it.
Comment 5 Dan Williams 2012-11-28 22:37:11 UTC 
4511581dba42cc4c32b32ad05f9c400673a5b051

Pushed, thanks!