GNOME Bugzilla – Bug 688797
Should support non-local image selection
Last modified: 2016-03-31 13:54:50 UTC
I have my ISOs on a samba server. gvfs-fuse allows having a local filename for remote SMB shares.
(In reply to comment #0) > I have my ISOs on a samba server. gvfs-fuse allows having a local filename for > remote SMB shares. That *should* work already. What happens when you run `gnome-boxes LOCAL_PATH_TO_ISO`?
(In reply to comment #1) > (In reply to comment #0) > > I have my ISOs on a samba server. gvfs-fuse allows having a local filename for > > remote SMB shares. > > That *should* work already. What happens when you run `gnome-boxes > LOCAL_PATH_TO_ISO`? Missed the point. The file chooser doesn't show them to me. (and what happens is that it breaks, see bug 688798)
Yeah, we need to disnable the local-only flag in the file selector, and then do all i/o via gio and use GFile instead of pathnames for this to work.
(In reply to comment #3) > Yeah, we need to disnable the local-only flag in the file selector, and then do > all i/o via gio and use GFile instead of pathnames for this to work. How would you tell qemu/libvirt to do that? Or you are thinking of downloading it before install if its non-local?
It might be that the fuse based emulation of local files doesn't work well enough for qemu, i guess we'd need to make a copy then.
Created attachment 243610 [details] [review] Revert "wizard: Confine file chooser dialog to local filesystem" This reverts commit cd688ab2d4b6bdfbeb8dfe4a6f86391cb8a1c1ce. Conflicts: src/wizard-source.vala
The attached patch should fix at least this bug. Related bug#688798 is a different story.
If things are still broken, better to keep remote files hidden for now. Any idea why you disabled this in the past?
(In reply to comment #8) > If things are still broken, better to keep remote files hidden for now. As per comment#0, at least some types of remote files have local paths and apparently confining dialog to local-only hides those as well. > Any > idea why you disabled this in the past? IIRC I didn't know this flag also covers remote filesystems with local paths.
(In reply to comment #9) > (In reply to comment #8) > > If things are still broken, better to keep remote files hidden for now. > > As per comment#0, at least some types of remote files have local paths and > apparently confining dialog to local-only hides those as well. My understanding of comment #2 and of bug #688798 is that these remote files made available through gvfs-fuse can't be successfully used by Boxes.
With bug#688798, I think this patch makes complete sense. Attachment 243610 [details] pushed as a84c9ad - Revert "wizard: Confine file chooser dialog to local filesystem"
Created attachment 279833 [details] [review] Revert "wizard: Confine file chooser dialog to local filesystem" This reverts commit cd688ab2d4b6bdfbeb8dfe4a6f86391cb8a1c1ce. Conflicts: src/wizard-source.vala
Comment on attachment 279833 [details] [review] Revert "wizard: Confine file chooser dialog to local filesystem" Ouch resubmitted the old and wrong patch. :(
commit: f32e682 f32e682583ad695f2edcdec167b2de3173e87815 Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org> Date: Thu Jul 3 12:33:40 2014 +0100 wizard-source: Allow selecting file from remote shares This was supposed to be covered by a84c9ad (Revert "wizard: Confine file chooser dialog to local filesystem") but what I didn't realize at that time was that the underlying Gtk.FileChooser.local_only property is by default true and not false. :( Explicitly setting this property now to enable access to remote shares.
(In reply to comment #14) > commit: f32e682 f32e682583ad695f2edcdec167b2de3173e87815 > Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org> > Date: Thu Jul 3 12:33:40 2014 +0100 > > wizard-source: Allow selecting file from remote shares > > This was supposed to be covered by a84c9ad (Revert "wizard: Confine file > chooser dialog to local filesystem") but what I didn't realize at that > time was that the underlying Gtk.FileChooser.local_only property is by > default true and not false. :( > > Explicitly setting this property now to enable access to remote shares. Same problem with meld Why local_only property is by default true? :(
It's occurs after update to 3.12 GTK
(In reply to comment #16) > It's occurs after update to 3.12 GTK That would be question to gtk+ devs.
(In reply to comment #16) > It's occurs after update to 3.12 GTK Are you sure about that cause in the gtk+ git history, I see that default value for this property has always been 'TRUE'.
Ahhh understand meld 3.10 use GTK 2 and 3.12 use GTK 3 dialog