After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688774 - main: Fix g_critical() on login
main: Fix g_critical() on login
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-21 00:55 UTC by Colin Walters
Modified: 2012-11-21 22:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Fix g_critical() on login (1.68 KB, patch)
2012-11-21 00:55 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-11-21 00:55:14 UTC 
Commit
http://git.gnome.org/browse/gnome-session/commit/?id=34c380508516f8a2f81b68d189b24fedb05870ea
caused us to emit a g_critical because we were passing NULL for the
user data, when the callback expected a GsmManager.  Fixing this
requires passing the user data later.
Comment 1 Colin Walters 2012-11-21 00:55:16 UTC 
Created attachment 229533 [details] [review]
main: Fix g_critical() on login
Comment 2 Bastien Nocera 2012-11-21 21:48:30 UTC 
Review of attachment 229533 [details] [review]:

Looks good.
Comment 3 Colin Walters 2012-11-21 22:08:20 UTC 
Attachment 229533 [details] pushed as 854edad - main: Fix g_critical() on login