After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688765 - Use GBytes for byte array GVariants
Use GBytes for byte array GVariants
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-20 23:34 UTC by Giovanni Campagna
Modified: 2012-11-21 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GBytes for byte array GVariants (2.07 KB, patch)
2012-11-20 23:34 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-11-20 23:34:28 UTC 
Gjs has now support for dealing transparently with GBytes, and this
allows us to avoid a copy in the common case of carrying a blob around
(such as when receiving an image over DBus)
Comment 1 Giovanni Campagna 2012-11-20 23:34:31 UTC 
Created attachment 229520 [details] [review]
Use GBytes for byte array GVariants
Comment 2 Colin Walters 2012-11-21 18:20:19 UTC 
Review of attachment 229520 [details] [review]:

Ouch...in the old ay path we didn't even use byteArray, but a real JS array of doubles?  That's a lot of memory.

Anyways, looks good to me!
Comment 3 Giovanni Campagna 2012-11-21 21:49:45 UTC 
Attachment 229520 [details] pushed as 8120cb5 - Use GBytes for byte array GVariants