After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688744 - Don't use gtk_style_context_set_background() to render icon/tree views
Don't use gtk_style_context_set_background() to render icon/tree views
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-11-20 17:45 UTC by Cosimo Cecchi
Modified: 2012-11-20 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
iconview: don't use gtk_style_context_set_background() (5.72 KB, patch)
2012-11-20 17:45 UTC, Cosimo Cecchi
committed Details | Review
tree-view: don't use gtk_style_context_set_background() (3.36 KB, patch)
2012-11-20 17:45 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2012-11-20 17:45:43 UTC
See attached patches.
Comment 1 Cosimo Cecchi 2012-11-20 17:45:45 UTC
Created attachment 229490 [details] [review]
iconview: don't use gtk_style_context_set_background()

Render a background with gtk_render_background() during draw instead.
Comment 2 Cosimo Cecchi 2012-11-20 17:45:48 UTC
Created attachment 229491 [details] [review]
tree-view: don't use gtk_style_context_set_background()

Render a background with gtk_render_background() in draw() instead.
Note that we still use gtk_style_context_set_background() for the header
window.
Comment 3 Cosimo Cecchi 2012-11-20 18:42:33 UTC
Attachment 229490 [details] pushed as da09447 - iconview: don't use gtk_style_context_set_background()
Attachment 229491 [details] pushed as ddcedda - tree-view: don't use gtk_style_context_set_background()