After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688717 - If the displayed VM goes into a "weird" state we don't exit to collection view
If the displayed VM goes into a "weird" state we don't exit to collection view
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-20 11:22 UTC by Alexander Larsson
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
On display disconnect, only go to COLLECTION for current item (1.01 KB, patch)
2012-11-20 11:26 UTC, Alexander Larsson 		committed Details | Review
Exit to collection view if the VM goes to a non-running state (1.36 KB, patch)
2012-11-20 11:26 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2012-11-20 11:22:28 UTC 
If you're showing a VM and it gets a state change, for instance it gets paused from outside gnome-boxes, or the guest decides to go into S3 sleep mode then we don't currently exit the VM, but rather keep showing something useless that you can't do anything with.

In the case of pause we show a frozen vm, in the case of sleep we show a grey screen (as we get a display !ready signal and hide the display).
Comment 1 Alexander Larsson 2012-11-20 11:26:48 UTC 
Created attachment 229465 [details] [review]
On display disconnect, only go to COLLECTION for current item

If the display was still around due to e.g. keeping it alive
for usb device redirection we don't want to go to collection view
if another machine is showing.
Comment 2 Alexander Larsson 2012-11-20 11:26:51 UTC 
Created attachment 229466 [details] [review]
Exit to collection view if the VM goes to a non-running state

This is required for instance for the SLEEP and PAUSE mode, as
in these modes we can't use the spice display widget, but the
spice connection is not disconnected, so we don't currrently
exit to the collection view due to that.
Comment 3 Alexander Larsson 2012-11-20 11:29:05 UTC 
There is one additional issue here, if the guest goes to S3 sleep mode we seem to wake it up when closing the spice connection due to going to collection view.
This behaviour is still better than the old one of showing a grey window though, and i'm not sure how important it is to fix this since we disable s3 support for all new VMs these days.
Comment 4 Christophe Fergeau 2012-11-23 08:44:06 UTC 
Review of attachment 229465 [details] [review]:

Looks good
Comment 5 Christophe Fergeau 2012-11-23 08:45:47 UTC 
Review of attachment 229466 [details] [review]:

Lots of conditions to test, but makes sense.
Comment 6 Christophe Fergeau 2012-11-23 08:45:49 UTC 
Review of attachment 229466 [details] [review]:

Lots of conditions to test, but makes sense.
Comment 7 Alexander Larsson 2012-11-26 08:43:50 UTC 
Attachment 229465 [details] pushed as c03ea76 - On display disconnect, only go to COLLECTION for current item
Attachment 229466 [details] pushed as 0ed0307 - Exit to collection view if the VM goes to a non-running state