After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688715 - Unconfigured eraser should be set to eraser tool
Unconfigured eraser should be set to eraser tool
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.8.2
Other All
: Normal minor
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2012-11-20 11:04 UTC by Vince C.
Modified: 2013-03-14 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vince C. 2012-11-20 11:04:09 UTC
Hi.

Using Gimp 2.8.2 under Gentoo Linux. Tests made against two Wacom tablets: Cintiq 22HD and Bamboo Fun Pen & Touch.

Gimp 2.8 defaults to assigning the airbrush to the stylus *and* eraser until I change it. Either tips of the pen remain with the assigned brush until I close Gimp.

Here's what I did:

1. Make sure Gimp 2.8 starts as if run for the first time, run:
   find ~/.gimp-2.8 -delete
   Then run Gimp 2.8
2. enable Bamboo Fun (pad, pen, eraser) and Cintiq (pad, pen, eraser) devices, mode screen
3. use the pen: notice airbrush selected
5. flip the stylus to use the eraser: notice airbrush selected
5. select the eraser tool
6. flip back to the pen: notice airbrush selected
7. flip again to the eraser: notice eraser selected.

Repeat 3-7 for the other tablet.

Haven't tried other distributions.
Comment 1 Michael Schumacher 2012-11-20 13:07:12 UTC
Can anyone else reproduce this?
Comment 2 Jehan 2012-11-20 13:47:42 UTC
I just made the test on the git repository, with a tablet Wacom bamboo. I confirm the report.

And from memory, that was the same with another tablet (Wacom Intuos), though I can't test right now with this one. So it looks like a general behavior.

And I agree with the reporter that if the default tool of the eraser side of the pen was actually the eraser tool, that would be much more user-friendly. :-)
Comment 3 Michael Natterer 2012-11-22 22:49:28 UTC
Fixed in master and gimp-2-8, while technically not a bugfix, it is
trivial enough to backport.

commit 54ae57f2900e41fb62b09bf7bfeb7214eb6b55f9
Author: Michael Natterer <mitch@gimp.org>
Date:   Thu Nov 22 23:43:41 2012 +0100

    Bug 688715 - Unconfigured eraser should be set to eraser tool
    
    If a device has no saved settings, and it is a GDK_SOURCE_ERASER, set
    it to the eraser tool.
    (cherry picked from commit 512fbcbbb23c0c449184b90d942dc7241d96b1a8)

 app/widgets/gimpdevicemanager.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 4 Vince C. 2012-11-22 23:47:35 UTC
Thanks Michael. The patch will go nicely in an updated ebuild for Gentoo here.
Comment 5 Michael Natterer 2012-11-23 00:26:00 UTC
Had I known I would mess up like this, this wouldn't have landed in 2.8,
so what... really fixed now:

commit 67a1f9e40c6839ab5103145b8bbe18cce6d53416
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Nov 23 01:17:52 2012 +0100

    Bug 688715 - Unconfigured eraser should be set to eraser tool
    
    I don't know what I tested before, but it didn't work. This patch does
    the magic in two places, one of which I missed.
    (cherry picked from commit 4e340b613bb7bf0730572bb123d67e9fb6671934)

 app/widgets/gimpdeviceinfo.c    |   21 +++++++++++++++++++++
 app/widgets/gimpdeviceinfo.h    |    2 ++
 app/widgets/gimpdevicemanager.c |   14 +-------------
 app/widgets/gimpdevices.c       |    2 ++
 4 files changed, 26 insertions(+), 13 deletions(-)
Comment 6 Vince C. 2013-03-13 07:53:24 UTC
Hi Michael.

A few months later I have to let you know that this bug is still present. I have upgraded Gimp to 2.8.4 on Gentoo and (starting with a profile [re]set to pristine state) had to configure the eraser on *all* my tablets (i.e. Wacom Cintiq 22HD and Wacom Bamboo Fun|Comic Pen & Touch). Yesterday a friend of mine downloaded and installed the latest Windows version of Gimp 2.8 and again had to do the same with his Wacom Graphire as I did with my tablets: enable the tablet in preferences, close the dialog, flip the pen, select eraser, flip the pen, make sure eraser is not selected, open preferences > input devices, save state. We checked MyPaint, it does correctly select the eraser when we flip the pen so it's not that our tablet is misconfigured. Do you have an idea what's going wrong?
Comment 7 Michael Natterer 2013-03-13 11:54:23 UTC
Did it by any chance migrate your old 2.6 settings on these machines? I'm
pretty sure I tested it correctly after the first attempt, but will check
again.
Comment 8 Vince C. 2013-03-13 13:00:21 UTC
(In reply to comment #7)
> Did it by any chance migrate your old 2.6 settings on these machines? I'm
> pretty sure I tested it correctly after the first attempt, but will check
> again.

There is indeed my old 2.6 profile on my machines. I deleted all the profile directories, older and newest, restarted Gimp, enabled the tablet and yes, flipping the pen for the eraser now enables the eraser tool. Sorry for the noise.
Comment 9 Vince C. 2013-03-13 13:43:30 UTC
As a supplement of information, my friend, who was using his older Graphire hadn't installed Gimp 2.6 at all and had no previous profile (he reinstalled his computer a few weeks ago from scratch, he didn't restore his windows profile and only installed Gimp 2.8 lately). It is the Windows version of Gimp. He experienced the bug as I earlier described.
Comment 10 Michael Natterer 2013-03-13 17:55:18 UTC
The windows GDK backend never sets ERASER, so GIMP has no chance of
doing anything here.
Comment 11 Vince C. 2013-03-14 08:02:27 UTC
Developer curiosity: I suppose it does set something usable anyway as once Gimp is configured the eraser and stylus are used as different tools. Also since MyPaint needs no such configuration under Windows I guess there's a platform-specific workaround, right?
Comment 12 Michael Natterer 2013-03-14 09:25:13 UTC
I don't have windows and can't check.