GNOME Bugzilla – Bug 688682
Wrap g_variant_type_new_tuple()
Last modified: 2012-11-21 04:02:21 UTC
Created attachment 229411 [details] [review] VariantType: Implement VariantType::create_tuple() Wrapping g_variant_type_new_tuple() was marked TODO in varianttype.hg, so I went ahead and implemented it following the style of Variant::create_tuple. I marked the document as "Since 3.8" but I don't know if that's really appropriate or not.
Review of attachment 229411 [details] [review]: The patch looks good. ::: glib/src/varianttype.hg @@ +124,3 @@ + * + * @param items A vector of VariantTypes, one for each item. + * @return A new tuple VariantType Just add a period at the end. @@ +126,3 @@ + * @return A new tuple VariantType + * + * Since 3.8 This should use an @newin{} directive as is done generally. It should be @newin{2,36} because it will go into glibmm.
Created attachment 229511 [details] [review] VariantType: Implement VariantType::create_tuple() >Just add a period at the end. Done >It should be @newin{2,36} because it will go into glibmm. Done It also now applies cleanly against d95b42
Created attachment 229512 [details] [review] VariantType: Implement VariantType::create_tuple() Uploaded the wrong file before, this one is the right version.
Pushed to the master branch of glibmm with a ChangeLog entry: http://git.gnome.org/browse/glibmm/commit/?id=fadf0377c5f4513ddc2175a091d55fe76d7a44a4 Murray, the glibmm maintainer, always requests that the ChangeLog file be updated. The following page explains the different tools available to deal with modifying the ChangeLog file: https://live.gnome.org/ChangeLog