After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688677 - videoflip: Add gray 8/16 support
videoflip: Add gray 8/16 support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-19 20:41 UTC by Joshua M. Doe
Modified: 2012-11-20 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tested patch for 0.10 (1.84 KB, patch)
2012-11-19 20:41 UTC, Joshua M. Doe 		needs-work Details | Review
untested patch for 1.0 (1.97 KB, patch)
2012-11-19 20:41 UTC, Joshua M. Doe 		committed Details | Review
updated patch for 0.10 using LITTLE_ENDIAN and BIG_ENDIAN string (1.89 KB, patch)
2012-11-20 12:39 UTC, Joshua M. Doe 		committed Details | Review

Description Joshua M. Doe 2012-11-19 20:41:17 UTC 
Created attachment 229406 [details] [review]
tested patch for 0.10

Trivial patch to add GRAY8 and GRAY16_(LE|BE) support to videoflip.
Comment 1 Joshua M. Doe 2012-11-19 20:41:41 UTC 
Created attachment 229407 [details] [review]
untested patch for 1.0
Comment 2 Sebastian Dröge (slomo) 2012-11-20 11:52:23 UTC 
Review of attachment 229406 [details] [review]:

::: gst/videofilter/gstvideoflip.c
@@ +101,3 @@
         GST_VIDEO_CAPS_YUV ("NV12") ";" GST_VIDEO_CAPS_YUV ("NV21") ";"
+        GST_VIDEO_CAPS_YUV ("YVYU") ";" GST_VIDEO_CAPS_GRAY8 ";"
+        GST_VIDEO_CAPS_GRAY16 ("1234") ";" GST_VIDEO_CAPS_GRAY16 ("4321")

Use G_LITTLE_ENDIAN and G_BIG_ENDIAN here
Comment 3 Sebastian Dröge (slomo) 2012-11-20 11:52:49 UTC 
1.0 version pushed:

commit fe9fb8d8a74d671894e80e39f8b9b99d2738a816
Author: Joshua M. Doe <oss@nvl.army.mil>
Date:   Mon Nov 19 03:31:37 2012 -0500

    videoflip: Add gray 8/16 support
Comment 4 Tim-Philipp Müller 2012-11-20 12:00:27 UTC 
> +        GST_VIDEO_CAPS_GRAY16 ("1234") ";" GST_VIDEO_CAPS_GRAY16 ("4321")
> 
> Use G_LITTLE_ENDIAN and G_BIG_ENDIAN here

"LITTLE_ENDIAN" and "BIG_ENDIAN" rather, I think.
Comment 5 Joshua M. Doe 2012-11-20 12:39:17 UTC 
Created attachment 229469 [details] [review]
updated patch for 0.10 using LITTLE_ENDIAN and BIG_ENDIAN string
Comment 6 Sebastian Dröge (slomo) 2012-11-20 12:49:13 UTC 
commit 9c917b84916e57f1b4312a36de5bae013dca58e9
Author: Joshua M. Doe <oss@nvl.army.mil>
Date:   Mon Nov 19 03:22:13 2012 -0500

    videoflip: Add gray 8/16 support