Created attachment 229361 [details] [review]
Display user friendly error on medium analysis failures

Review of attachment 229361 [details] [review]:

::: src/wizard.vala
@@ +290,3 @@
         } catch (GLib.Error error) {
+            debug("Failed to analyze installer image: %s", error.message);
+            App.app.notificationbar.display_error (_("Failed to analyze installer image"));

We dont know if its an 'image', it could be real media. Also I'm not sure we should expect user to know what an "image" is. s/image/media/. I'd also show the path to the media in the message so user can check whats wrong with it. Perhaps we should append with ". Corrupted or incomplete media?" to show that its not exactly our fault?

BTW, you want a '.' at the end. :)

Review of attachment 229361 [details] [review]:

::: src/wizard.vala
@@ +290,3 @@
         } catch (GLib.Error error) {
+            debug("Failed to analyze installer image: %s", error.message);
+            App.app.notificationbar.display_error (_("Failed to analyze installer image"));

Are we going through this code path for actual media? I though we didn't have enough permissions to read the raw ISO data from a real CD and that we went through a different code path? ACK on the "corrupted" part, given that we don't show the path in the UI before, I'm not sure we should show it there.

Review of attachment 229361 [details] [review]:

::: src/wizard.vala
@@ +290,3 @@
         } catch (GLib.Error error) {
+            debug("Failed to analyze installer image: %s", error.message);
+            App.app.notificationbar.display_error (_("Failed to analyze installer image"));

Now that you mention it, we don't but this will *most probably* change when remove the libosinfo udev rule (we'll only know then that its a bootable media and will have to scan it in app). Besides, I really prefer the term "media" over "image" here.

Created attachment 229384 [details] [review]
Display user friendly error on medium analysis failures

When trying to install from a corrupted ISO (for example a 0-byte)
ISO, the error from libosinfo is displayed to the user, and these
are not user friendly messages. Replace it with a user-friendly
message, and only log the initial error to the console.

Review of attachment 229384 [details] [review]:

ACK