GNOME Bugzilla – Bug 688603
document-manager: Update combo filenames when the project changes.
Last modified: 2012-11-19 20:02:14 UTC
So that the filenames always are shown relative to the project root.
Created attachment 229305 [details] [review] document-manager: Update combo filenames when the project changes.
Review of attachment 229305 [details] [review]: Thanks for your patch, I have two comments on it. Why have you removed the lines in value_added_project_root_uri? g_free (doc_plugin->project_name); g_free (doc_plugin->project_path); doc_plugin->project_name = NULL; I suppose it's because you have found that value_removed_project_root_uri is always called first. But even in this case, I think it's better to keep it or at least put a comment here saying that value_removed_project_root_uri has to be called first. I think it's better to not use g_clear_pointer for the moment. It is a new function available in GLib 2.34 while currently Anjuta needs only version 2.32 and I think it's not a major improvement.
Created attachment 229401 [details] [review] document-manager: Update combo filenames when the project changes.
Right, I thought value_removed_project_root_uri always would be called before a new value_added_project_root_uri but I now realize that's not true. I've attached a new patch that fixes this and also changes the g_clear_pointer to g_free().
Comment on attachment 229401 [details] [review] document-manager: Update combo filenames when the project changes. Thank again for this patch. I have committed it.