After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688578 - add a privacy schema
add a privacy schema
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 687774
 
 
Reported: 2012-11-18 05:54 UTC by Matthias Clasen
Modified: 2012-11-19 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.74 KB, patch)
2012-11-18 05:54 UTC, Matthias Clasen
needs-work Details | Review
revised patch (1.76 KB, patch)
2012-11-19 04:29 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2012-11-18 05:54:17 UTC
Created attachment 229278 [details] [review]
patch

For now, this just contains a 'steath-mode' key, which is needed for the privacy panel design. More may follow
Comment 1 Bastien Nocera 2012-11-18 10:20:38 UTC
Review of attachment 229278 [details] [review]:

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +2,3 @@
+<schemalist>
+  <schema id="org.gnome.desktop.privacy" path="/org/gnome/desktop/privacy/">
+    <key name="stealth-mode" type="b">

Could you find a better name for the settings key? "hide-identity"?

@@ +6,3 @@
+      <_summary>Controls visibility of private information</_summary>
+      <_description>If set to true, the system will make an effort to
+      not display the users identity publically.</_description>

What does "publically" mean here?
Comment 2 Matthias Clasen 2012-11-19 04:29:14 UTC
Created attachment 229333 [details] [review]
revised patch
Comment 3 Bastien Nocera 2012-11-19 08:18:23 UTC
Review of attachment 229333 [details] [review]:

The commit message still mentions "stealth-mode".

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +6,3 @@
+      <_summary>Controls visibility of personal information</_summary>
+      <_description>If set to true, the system will make an effort to
+      not display the user's identity on screen or on the network.</_description>

It doesn't really display it on the network though...
Comment 4 Matthias Clasen 2012-11-19 16:09:53 UTC
sorry about the commit message. The network bit will become relevant when the privacy panel design is fully implemented:

https://live.gnome.org/Design/SystemSettings/Privacy
Comment 5 Bastien Nocera 2012-11-19 16:13:14 UTC
(In reply to comment #4)
> sorry about the commit message.

np

> The network bit will become relevant when the
> privacy panel design is fully implemented:

It was more the use of "display". I used "divulge" instead.