After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688576 - add a show-full-name key in the screensaver schema
add a show-full-name key in the screensaver schema
Product: gsettings-desktop-schemas
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
Depends on:
Blocks: 688577
Reported: 2012-11-18 04:49 UTC by Matthias Clasen
Modified: 2012-11-19 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (1.31 KB, patch)
2012-11-18 04:49 UTC, Matthias Clasen
needs-work Details | Review
revised patch (1.31 KB, patch)
2012-11-19 04:26 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Matthias Clasen 2012-11-18 04:49:18 UTC
Created attachment 229276 [details] [review]

This is needed to implement the privacy panel, see bug 687774
Comment 1 Bastien Nocera 2012-11-18 10:24:16 UTC
Review of attachment 229276 [details] [review]:

::: schemas/
@@ +22,3 @@
+    <key name="show-full-name" type="b">
+      <default>false</default>

Why is the default false?
The current behaviour is to show it, so I'd like to have a separate patch to turn the setting off, along with an explanation as to why it would be false.

@@ +24,3 @@
+      <default>false</default>
+      <_summary>Show full name in the lock screen</_summary>
+      <_description>Whether the users full name is shown in the lock screen or not. This only affects the screen shield, the name is always shown in the unlock dialog.</_description>

Comment 2 Matthias Clasen 2012-11-19 04:26:17 UTC
Created attachment 229332 [details] [review]
revised patch
Comment 3 Bastien Nocera 2012-11-19 08:24:10 UTC
Review of attachment 229332 [details] [review]: