After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688542 - PATCH: Usergroup page (layout.xml) has mismatch in <div>
PATCH: Usergroup page (layout.xml) has mismatch in <div>
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.2-SVN
Other All
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2012-11-17 15:26 UTC by René Papenhoven
Modified: 2012-12-26 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Usergroup <div> mismatch fix (129.24 KB, application/octet-stream)
2012-11-17 15:26 UTC, René Papenhoven
  Details
Patch for index.cpp (350 bytes, patch)
2012-11-18 15:08 UTC, René Papenhoven
none Details | Review

Description René Papenhoven 2012-11-17 15:26:34 UTC
Created attachment 229242 [details]
Usergroup <div> mismatch fix

A usergroup html page (via a "usergroup" entry in layout.xml) has one <div/> to many.

This is caused (index.cpp) by a call to endContents (via endFile) without a startContents when creating the usergroup html code.

Probably adding startContents is the best and/or easiest solution.
This fix has been attached (based on revision 832).
Comment 1 Dimitri van Heesch 2012-11-18 11:01:46 UTC
Hi Rene, thanks for the fix. 

Could you please make a real patch instead of sending the whole file?
i.e. use 
diff -u doxygen_org/src/index.cpp doxygen_modified/src/index.cpp >index.patch

That way I can more easily apply it.
Comment 2 René Papenhoven 2012-11-18 15:08:55 UTC
Created attachment 229290 [details] [review]
Patch for index.cpp

Hi Dimitri, you're welcome.

I've attached the patch.
Comment 3 Dimitri van Heesch 2012-12-26 16:09:17 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.3. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.