After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688517 - libcaribou: refactor some code
libcaribou: refactor some code
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-17 07:24 UTC by Daiki Ueno
Modified: 2012-11-22 08:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libcaribou: refactor some code (7.86 KB, patch)
2012-11-17 07:24 UTC, Daiki Ueno 		accepted-commit_now Details | Review
libcaribou: refactor some code (13.24 KB, patch)
2012-11-20 01:48 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2012-11-17 07:24:41 UTC 
Another minor issues.  I'll commit this soon if no objections.
Comment 1 Daiki Ueno 2012-11-17 07:24:43 UTC 
Created attachment 229215 [details] [review]
libcaribou: refactor some code

Use Gee lists and hashtables extensively instead of GLib's;
specify proper cname to libxklavier signals to avoid using
a static signal handler.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-11-19 13:40:30 UTC 
Review of attachment 229215 [details] [review]:

Looks good to me
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-11-19 13:40:32 UTC 
Review of attachment 229215 [details] [review]:

Looks good to me
Comment 4 Daiki Ueno 2012-11-20 01:48:38 UTC 
Created attachment 229433 [details] [review]
libcaribou: refactor some code

Thanks for the review.  I would like to commit this with one more minor change: eliminate unnecessary "using" statements at the beginning of each vala file.
Comment 5 Daiki Ueno 2012-11-22 08:28:06 UTC 
Attachment 229433 [details] pushed as aac5964 - libcaribou: refactor some code