After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688486 - GstPhotography: add new enum values for android
GstPhotography: add new enum values for android
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-16 19:05 UTC by Youness Alaoui
Modified: 2012-11-20 09:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GstPhotography: Add new enum values to match android's parameters (1.94 KB, patch)
2012-11-16 19:05 UTC, Youness Alaoui 		committed Details | Review
Patch for master branch (4.12 KB, patch)
2012-11-20 00:31 UTC, Youness Alaoui 		committed Details | Review

Description Youness Alaoui 2012-11-16 19:05:17 UTC 
Created attachment 229176 [details] [review]
GstPhotography: Add new enum values to match android's parameters

In order to match the capabilities of the android camera parameters, I've added some enum values to the GstPhotography interface. See attached patch.
For documentation on the new enums and capabilities of android cameras, see here : http://developer.android.com/reference/android/hardware/Camera.Parameters.html
Comment 1 Tim-Philipp Müller 2012-11-16 23:16:47 UTC 
Could you please also provide a patch against git master?
Comment 2 Youness Alaoui 2012-11-20 00:31:58 UTC 
Created attachment 229429 [details] [review]
Patch for master branch

Here's the patch applied to the master git. I thought it was apply directly, but there were small changes needed. COLOR_TONE instead of COLOUR_TONE and I also added gtk-doc for the new enums.
Thanks.
Comment 3 Tim-Philipp Müller 2012-11-20 09:45:52 UTC 
Thanks, also added some Since markers:

 commit faf7370a27717665eb5d12d71682bdae3ce5d06a
 Author: Youness Alaoui <youness.alaoui@collabora.co.uk>
 Date:   Mon Nov 19 19:29:48 2012 -0500

    GstPhotography: Add new enum values to match android's parameters
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688486