After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688427 - [patch] regression in EXIF orientation parsing
[patch] regression in EXIF orientation parsing
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
2.26.x
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-15 21:37 UTC by Tormod Volden
Modified: 2012-11-20 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
git formatted patch restoring the correct EXIF parsing (3.20 KB, patch)
2012-11-15 21:37 UTC, Tormod Volden 		accepted-commit_now Details | Review

Description Tormod Volden 2012-11-15 21:37:00 UTC 
Created attachment 229099 [details] [review]
git formatted patch restoring the correct EXIF parsing

From https://bugs.launchpad.net/bugs/1077186 (appeared in Ubuntu 12.10):

"On upgrading to Ubuntu 12.10, I find that glslideshow is ignoring rotation data in pictures taken by my Nikon D7000 camera, and so portrait pictures are shown rotated by 90 degrees. An example of such an image is:"

"It also works in Ubuntu 12.04. In Quantal it worked with gdk-pixbuf 2.26.3-0ubuntu1 and broke with 2.26.4-0ubuntu1."

The original reporter's example JPEG was in "Motorola" format (big-endian) and had orientation value of 8.

ltrace showed that gdk_pixbuf_apply_embedded_orientation() was called but returned the unmodified pixbuf.

This is a regression introduced in http://git.gnome.org/browse/gdk-pixbuf/commit/gdk-pixbuf/io-jpeg.c?id=0179dfdc2bfe02bcf3f3a2c92878be0c3da9c192 and released in 2.26.4 (see also bug #604610).
Comment 1 Matthias Clasen 2012-11-18 16:31:05 UTC 
Review of attachment 229099 [details] [review]:

thanks for tracking that down