After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688409 - make install fails when valadoc is disabled
make install fails when valadoc is disabled
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-15 16:18 UTC by regis.merlino
Modified: 2012-11-21 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (945 bytes, patch)
2012-11-15 16:18 UTC, regis.merlino 		none Details | Review
Proposed patch - v2 (1.15 KB, patch)
2012-11-20 16:57 UTC, regis.merlino 		committed Details | Review

Description regis.merlino 2012-11-15 16:18:45 UTC 
Created attachment 229063 [details] [review]
Proposed patch

When using the --disable-valadoc flag, doing a "make install" fails with errors.
See below for the output.

I attached a proposed patch to fix this.


make  install-data-hook
make[6]: Entering directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc/reference/librygel-core'
/bin/mkdir -p
/bin/mkdir: missing operand
Try `/bin/mkdir --help' for more information.
make[6]: *** [install-data-hook] Error 1
make[6]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc/reference/librygel-core'
make[5]: *** [install-data-am] Error 2
make[5]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc/reference/librygel-core'
make[4]: *** [install-am] Error 2
make[4]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc/reference/librygel-core'
make[3]: *** [install-recursive] Error 1
make[3]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc/reference'
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1/doc'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/xxx/home:xxx:rygel/rygel17/rygel-0.17.1'
Comment 1 Murray Cumming 2012-11-19 11:02:33 UTC 
Wouldn't this prevent the documentation from being installed when building from a tarball? Note that the generated html is distributed in the tarball, so you don't need --enable-valadoc in that case.
Comment 2 regis.merlino 2012-11-20 16:57:49 UTC 
Created attachment 229487 [details] [review]
Proposed patch - v2

You're right.

I attached a new proposed patch that fixes the build when installing from the tarball: the RYGEL_GTKDOC_INSTALL_DIR variable was not initialized.

This does not fix errors when installing from non-tarball with the --disable-valadoc flag, but this case is less critical and you can probably go faster than me to find what's going on.