GNOME Bugzilla – Bug 688393
Scrollbar on notification bubbles looks bad
Last modified: 2012-11-26 14:02:34 UTC
Created attachment 229042 [details] Zoomed screenshot bit hilighting bad positioning The scrollbar distance from the side edge of the bubble is 2px more then the one from top/bottom edges and the bubble border radius clashes with the scrollbar rounded part. To keep that side distance the top/bottom distance should be increased by 2px and the bubble radius should be 15px to not clash. Reducing side/top/bottom distance value should allow a lesser radius. Here's a pair of screenshots hilighting the issue.
Created attachment 229043 [details] Zoomed screenshot bit hilighting arches clashing
Created attachment 229069 [details] [review] messageTray: modify bubble scrollview notification padding to have the same padding at right, bottom, top and left since having different padding make scrollbar looks ugly.
Lapo, do you have a good jhbuild to test it? If so, test it in your case please.
(In reply to comment #2) > Created an attachment (id=229069) [details] [review] > messageTray: modify bubble scrollview notification padding to have the same > padding at right, bottom, top and left since having different padding make > scrollbar looks ugly. Won't apply here.
Created attachment 229134 [details] before and after screenshot Ignore me - I was being stupid. See the attached screenshot - before is on the left, after is on the right.
Good =) I was getting crazy searching why it didn't apply to you. So, the result of the patch is good for you?
Judging by the screenshot the bubble rounder corner radius still clashes with the scrollbar rounded part, anyway it's already better then before.
Seems that the padding has been changed but the corner radius hasn't. I'd be happy to push as is, or to wait and add the extra modification.
Oh, I didn't understand good the clash problem. Wait Allan, I will fix it.
Choose the best for you. No clashing: 10 radius, 3 padding (10 radius is the same as notification radius, so more consistence): http://postimage.org/image/3vvx9agjt/ 13 radius, 6padding: http://postimage.org/image/4t6hctqa3/ 15 radius, 8 padding http://postimage.org/image/upxrjrlf9/ Clashing: 8 radius, 8 padding (previous radius, previous padding adjusted): http://postimage.org/image/4are5gywt/ 8 radius, 12 padding (previous radius, more padding): http://postimage.org/image/51k4b91a5/ 10 radius, 8 padding(10 radius is the same as notification radius, so more consistence): http://postimage.org/image/o9ostocvp/
All of them are better then the current state (good work!), I'd personally go 15/8.
Created attachment 229364 [details] [review] MessageTray: modify bubble scrollview notification padding to have the same padding at right, bottom, top and left since having different padding make scrollbar looks missaligned. Also adjust border radius of bubble to not clash the scrollbar.
Created attachment 229464 [details] screenshot Here's a couple of screenshots of the patch in action. Unfortunately, it seems to be throwing off the padding at the top of the popup. This may be a result of bug 688718.
Allan, I noticed this bug before my fixes. But I didn't fixed it because its outside the scope of this bug. If you do the same but without apply the patch you will notice it. Is it ok? Or do you want that I fix it in this bug report?
(In reply to comment #14) > If you do the same but without apply the patch you will notice it. Ah, indeed. > Is it ok? Or do you want that I fix it in this bug report? Seems like that's a separate bug. Let's get this landed as is.
Comment on attachment 229364 [details] [review] MessageTray: modify bubble scrollview notification padding to have the same padding at right, bottom, top and left since having different padding make scrollbar looks missaligned. Also adjust border radius of bubble to not clash the scrollbar. Pushed. (I tidied up the commit message and added a title.)
Nice fix. Thanks Carlos!