GNOME Bugzilla – Bug 688367
tags: Some mojibake happens when chars encoded with local charset are saved with ISO-8895-1 in an id3v2 text frame.
Last modified: 2018-11-03 11:22:58 UTC
Created attachment 229025 [details] [review] try more to guess charset I have a mp3 file with GBK chars saved with ISO-8895-1 in an id3v2 text frame. I know currently gstreamer is trying to guess the original charset according the current locale. However there is a problem that if you locale is *.UTF-8, gstreamer regards that the possible charset is just UTF-8. I think it can do more to guess the possible charset with the prefix in *.UTF-8. It might be that for example if current locale is zh_CN.UTF-8, gstreamer could try zh_CN.GBK, zh_CN.GB2312 to guess the oirginal charset. And I make a patch about this.
Hi I mistook the component of this bug. It should be gst-plugins-base.
That's an interesting and simple approach, looks like a good idea.
Review of attachment 229025 [details] [review]: ::: gst-libs/gst/tag/id3v2frames.c @@ +965,3 @@ + GList *sets = NULL; + + const char *raw; Should we use an include here. Ideally that file gets updated for releases. @@ +1090,3 @@ + }; + + }, you can use G_N_ELEMENTS()
Still valid and would be great to have. Lance: can you update the patch to current master and take into account the last comments ?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/77.