Bug 688330 – Crash in lookup_resolved(), g_error_free()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 688330 - Crash in lookup_resolved(), g_error_free()


Summary:	Crash in lookup_resolved(), g_error_free()


Status:	RESOLVED FIXED

Product:	libsoup
Classification:	Core
Component:	Misc
Version:	2.41.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	libsoup-maint@gnome.bugs
QA Contact:	libsoup-maint@gnome.bugs

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-11-14 16:53 UTC by Milan Crha
Modified:	2012-11-15 08:01 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
proposed libsoup patch (452 bytes, patch) 2012-11-14 16:57 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2012-11-14 16:53:00 UTC

Moving this from bug #687877 comment #10:

+ Trace 231176

Thread 1 (Thread 0x914ffb70 (LWP 22160))

#0 free
from /lib/libc.so.6
#1 standard_free
at gmem.c line 98
#2 g_free
at gmem.c line 252
#3 g_error_free
at gerror.c line 476
#4 lookup_resolved
at soup-address.c line 697
#5 g_task_return_now
at gtask.c line 1099
#6 complete_in_idle_cb
at gtask.c line 1108
#7 g_idle_dispatch
at gmain.c line 4806
#8 g_main_dispatch
at gmain.c line 2715
#9 g_main_context_dispatch
at gmain.c line 3219
#10 g_main_context_iterate
at gmain.c line 3290
#11 g_main_loop_run
at gmain.c line 3484
#12 e_ews_soup_thread
at e-ews-connection.c line 1425
#13 g_thread_proxy
at gthread.c line 797
#14 start_thread
from /lib/libpthread.so.0
#15 clone
from /lib/libc.so.6

Comment 1 Milan Crha 2012-11-14 16:57:54 UTC

Created attachment 228980 [details] [review]
proposed libsoup patch

The problem is that g_task_return_error() "eats" the error, it doesn't create its own copy. Other occurrences seem fine.

Comment 2 Dan Winship 2012-11-14 17:09:45 UTC

Comment on attachment 228980 [details] [review]
proposed libsoup patch

yup

Comment 3 Milan Crha 2012-11-15 08:01:06 UTC

Created commit b2c900e in libsoup master (2.41.2+)