After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688289 - Use GNOME_COMPILE_WARNINGS([maximum])
Use GNOME_COMPILE_WARNINGS([maximum])
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-13 22:41 UTC by Colin Walters
Modified: 2012-11-22 03:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GNOME_COMPILE_WARNINGS([maximum]) (18.49 KB, patch)
2012-11-13 22:41 UTC, Colin Walters 		committed Details | Review
function.h: Fix prototype: () -> (void) (819 bytes, patch)
2012-11-13 22:41 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-11-13 22:41:49 UTC 
See patches.
Comment 1 Colin Walters 2012-11-13 22:41:51 UTC 
Created attachment 228939 [details] [review]
Use GNOME_COMPILE_WARNINGS([maximum])

In order to avoid getting spammed by warnings from including jsapi.h
which we don't control, centralize its inclusion in one place,
wrapping it with GCC pragmas to disable selected warnings.
Comment 2 Colin Walters 2012-11-13 22:41:53 UTC 
Created attachment 228940 [details] [review]
function.h: Fix prototype: () -> (void)

Needed with new compiler warnings.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-11-13 23:48:45 UTC 
Review of attachment 228940 [details] [review]:

Yes.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-11-13 23:51:48 UTC 
Review of attachment 228939 [details] [review]:

Sure.
Comment 5 Colin Walters 2012-11-14 13:25:57 UTC 
Attachment 228939 [details] pushed as e4d12cd - Use GNOME_COMPILE_WARNINGS([maximum])
Attachment 228940 [details] pushed as 6e17eeb - function.h: Fix prototype: () -> (void)
Comment 6 Allison Karlitskaya (desrt) 2012-11-22 03:27:27 UTC 
The header shuffling here caused bug 688617...

It's not entirely clear what the story should be for applications that want to

  #include <gi/[something].h>

since some of those headers pull in individual headers from gjs/ and those headers have single-include guards...

For now it seems that #include <gjs/gjs-module.h> before including anything from gi/ will fix the problem, but probably we want something more robust?