After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688253 - power: fix a warning at startup
power: fix a warning at startup
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-13 13:58 UTC by Cosimo Cecchi
Modified: 2012-11-13 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: fix a warning at startup (1.77 KB, patch)
2012-11-13 13:58 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-11-13 13:58:09 UTC 
This doesn't seem to be needed in git master, since the session proxy is created differently.
Comment 1 Cosimo Cecchi 2012-11-13 13:58:11 UTC 
Created attachment 228892 [details] [review]
power: fix a warning at startup

idle_configure() will call idle_is_session_inhibited(), which will warn
if the session proxy is not available. This will always be the case when
idle_configure() is called at startup, since we create it
asynchronously, so we'll always warn.
Remove the warning my moving the idle_configure() call to the session
proxy ready callback.
Comment 2 Bastien Nocera 2012-11-13 14:10:47 UTC 
Review of attachment 228892 [details] [review]:

s/my/by/

Looks good otherwise.
Comment 3 Cosimo Cecchi 2012-11-13 14:41:26 UTC 
Attachment 228892 [details] pushed as 179a11e - power: fix a warning at startup

Thanks, pushed.