After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688245 - Add tmdb plugin tests
Add tmdb plugin tests
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-13 13:12 UTC by Murray Cumming
Modified: 2012-11-16 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-tests-Add-tests-for-tmdb-plug-in.patch (44.25 KB, patch)
2012-11-13 13:12 UTC, Murray Cumming
committed Details | Review
0002-tests-Add-some-to-make-check.patch (983 bytes, patch)
2012-11-13 13:13 UTC, Murray Cumming
committed Details | Review

Description Murray Cumming 2012-11-13 13:12:48 UTC
Created attachment 228882 [details] [review]
0001-tests-Add-tests-for-tmdb-plug-in.patch

These tests use grilo's new mocking framework.
Comment 1 Murray Cumming 2012-11-13 13:13:49 UTC
Created attachment 228883 [details] [review]
0002-tests-Add-some-to-make-check.patch

And this patch makes sure that the tmdb tests are run during make distcheck, so we can catch problems without them getting into releases.
Comment 2 Murray Cumming 2012-11-13 13:22:49 UTC
These commits are also here: http://git.gnome.org/browse/grilo-plugins/log/?h=tmdb-test
Comment 3 Juan A. Suarez Romero 2012-11-16 13:43:11 UTC
commit 509db03ac058eabfab7c8b8108d31bccdcb3b900
Author: Murray Cumming <murrayc@murrayc.com>
Date:   Tue Nov 13 13:48:20 2012 +0100

    tests: Add some to make check
    
    These will then be built and run during make check, and therefore
    during make distcheck.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688245

 test/Makefile.am | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

commit 2c2b5ea365408ef907b4f2639a8ba73a8fa57d41
Author: Jens Georg <jensg@openismus.com>
Date:   Tue Nov 13 10:32:05 2012 +0100

    tests: Add tests for tmdb plug-in
    
    With some changes by Murray Cumming to update this patch to
    the latest grilo API, split it into separate files so we can
    set GRL_NET_MOCKED before calling grl_init(), and to
    dist the test data files.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688245

 test/.gitignore                        |   5 +++++
 test/Makefile.am                       |  56 ++++++++++++++++++++++++++++++++++++++++++++++++++------
 test/test_tmdb_fast_resolution.c       | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/test_tmdb_full_resolution.c       | 151 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/test_tmdb_missing_configuration.c |  84 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/test_tmdb_preconditions.c         | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/test_tmdb_utils.c                 |  72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/test_tmdb_utils.h                 |  33 +++++++++++++++++++++++++++++++++
 8 files changed, 620 insertions(+), 6 deletions(-)