GNOME Bugzilla – Bug 688231
common: remove the use of some deprecated functions
Last modified: 2012-11-13 15:05:46 UTC
Remove the g_type_init function, which was deprecated in glib 2.35.1. The type system is now initialised automatically, so increase the glib requirement to 2.35.1 to ensure this. Remove the use of gdk_threads_enter and gdk_threads_leave as these functions have been deprecated. The code being protected by these functions doesn't appear to be used outside of the main thread, so they can be safely removed without replacement.
Created attachment 228867 [details] [review] common: remove the use of the deprecated g_type_init function The g_type_init function was deprecated in glib 2.35.1 and the type system is now initialised automatically.
Created attachment 228868 [details] [review] common: remove the use of the deprecated GDK thread functions These functions are not necessary as the code is never called outside of the main thread.
Review of attachment 228867 [details] [review]: ++
Review of attachment 228868 [details] [review]: gdk_threads_add_idle() should probably be replaced as well. But, really, the language choosers should be made fully async (the biggest blocker being gdm_get_all_language_names() which does sync I/O).
Created attachment 228886 [details] [review] common: remove the use of the GDK thread functions Remove the use of gdk_threads_enter and gdk_threads_leave functions, as they have been deprecated, and also replace gdk_threads_add_idle with g_idle_add.
Review of attachment 228886 [details] [review]: Looks good.
Attachment 228867 [details] pushed as 288c3f8 - common: remove the use of the deprecated g_type_init function Attachment 228886 [details] pushed as 7dab589 - common: remove the use of the GDK thread functions