After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688223 - Some introspection fixes to make vapigen happy
Some introspection fixes to make vapigen happy
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: Li Yuan
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-13 08:51 UTC by Daiki Ueno
Modified: 2012-11-14 05:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Some introspection fixes to make vapigen happy (822 bytes, patch)
2012-11-13 08:51 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2012-11-13 08:51:38 UTC 
Currently the generated gir file refers to dbus-1 (which is libdbus not in use) and lacks necessary package information.  Attaching a patch to fix them.  This will make it easy to generate Vala binding.
Comment 1 Daiki Ueno 2012-11-13 08:51:40 UTC 
Created attachment 228856 [details] [review]
Some introspection fixes to make vapigen happy
Comment 2 Mike Gorse 2012-11-13 21:50:06 UTC 
Comment on attachment 228856 [details] [review]
Some introspection fixes to make vapigen happy

This looks fine (it should only affect the .gir, anyway, and I'll trust you that it does what it should). Do you have commit access, or should I commit it?
Comment 3 Daiki Ueno 2012-11-14 00:26:30 UTC 
Yes, I'll commit this later today.  By the way, I think it would be nice that atspi vala binding is included in the vala distribution (currently atk binding is there).  Do you mind if I file a patch for that?
Comment 4 Daiki Ueno 2012-11-14 02:09:25 UTC 
Attachment 228856 [details] pushed as 2dfc461 - Some introspection fixes to make vapigen happy
Comment 5 Darxus 2012-11-14 03:27:29 UTC 
This commit (2dfc46133542e67813f137cd1da34e0baff737c0) causes at-spi2-core to fail with /home/darxus/source.test.master/at-spi2-core/atspi/atspi-application.h:28:23: fatal error: dbus/dbus.h: No such file or directory

Verified previous commit (d327a8a145484936440b44b51b791beccf9ef1d3) builds successfully.

More of the make output:

  CCLD   libatspi.la
  GEN    Atspi-2.0.gir
In file included from /home/darxus/source.test.master/at-spi2-core/atspi/atspi-accessible.h:33:0,
                 from /home/darxus/source.test.master/at-spi2-core/atspi/atspi.h:31,
                 from <stdin>:4:
/home/darxus/source.test.master/at-spi2-core/atspi/atspi-application.h:28:23: fatal error: dbus/dbus.h: No such file or directory

Anything else that would be useful?
Comment 6 Colin Walters 2012-11-14 04:51:04 UTC 
The commit was clearly wrong in this, so I just pushed a fix:

commit 0c1d8f1ee7b3910360b0c20123a10a7b92e68bbc
Author: Colin Walters <walters@verbum.org>
Date:   Tue Nov 13 23:47:56 2012 -0500

    atspi: Readd dbus-1 to introspection generation
    
    It is presently used in AtspiApplication.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=6882
Comment 7 Daiki Ueno 2012-11-14 04:53:15 UTC 
Oops, thanks for the quick fix and sorry for bothering you before the GNOME release.
Comment 8 Darxus 2012-11-14 05:22:12 UTC 
Verified (latest) commit 0c1d8f1ee7b3910360b0c20123a10a7b92e68bbc builds without error, thanks.