Created attachment 229395 [details] [review]
GObject: register interfaces before creating the class

Recent GType emits a warning and fails if g_type_add_interface_static()
is called on a GType that had its class referenced already, so we need
to register interfaces before even creating the JS class (as that references
the GType class)

Review of attachment 229395 [details] [review]:

Looks OK to me.  Please commit.

I have one comment though, which doesn't need to be addressed in this patch:

::: gi/object.c
@@ +2357,3 @@
+    g_type_add_interface_static(instance_type,
+                                interface_type,
+                                &interface_vtable);

Should we actually be using the _dynamic version and passing our plugin?

(In reply to comment #2)
> ::: gi/object.c
> @@ +2357,3 @@
> +    g_type_add_interface_static(instance_type,
> +                                interface_type,
> +                                &interface_vtable);
> 
> Should we actually be using the _dynamic version and passing our plugin?

I don't know - what difference does it make?

Comment on attachment 229395 [details] [review]
GObject: register interfaces before creating the class

Attachment 229395 [details] pushed as 2405137 - GObject: register interfaces before creating the class
Leaving open for the _dynamic question.

I assume there's nothing left to do here. Closing as FIXED. Please reopen or file a new issue if the _dynamic version should be used instead.