After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688144 - LTE-only modems should be handled as GSM ones
LTE-only modems should be handled as GSM ones
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-12 07:52 UTC by Aleksander Morgado
Modified: 2013-02-05 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for the issue. (1.14 KB, patch)
2012-11-12 07:55 UTC, Aleksander Morgado 		none Details | Review
Rebased patch (1.14 KB, patch)
2013-02-05 14:42 UTC, Aleksander Morgado 		committed Details | Review

Description Aleksander Morgado 2012-11-12 07:52:13 UTC 
The network indicator has some code in place to handle non-GSM non-CDMA LTE-only modems:

 } else if (this._capabilities & NetworkManager.DeviceModemCapabilities.LTE) {
     is_wwan = true;
     // FIXME: support signal quality
 }

These modems, if ever found, should be handled as GSM modems.
Comment 1 Aleksander Morgado 2012-11-12 07:55:38 UTC 
Created attachment 228759 [details] [review]
Patch for the issue.
Comment 2 Giovanni Campagna 2012-11-19 18:29:16 UTC 
Be aware that that code is being changed in bug 688144, which is pending review, and this patch would need rebasing.
Comment 3 Aleksander Morgado 2012-11-19 21:35:01 UTC 
Giovanni: The bug you pointed out is actually this bug :-)
Comment 4 Giovanni Campagna 2012-11-19 22:23:26 UTC 
Ops, sorry, I meant bug 681146
Comment 5 Aleksander Morgado 2013-02-05 14:42:03 UTC 
Created attachment 235213 [details] [review]
Rebased patch

Rebased the patch on top of git master.
Comment 6 Giovanni Campagna 2013-02-05 14:48:55 UTC 
Review of attachment 235213 [details] [review]:

Bah, let's get this in.
Comment 7 Aleksander Morgado 2013-02-05 14:50:16 UTC 
Great :) pushed now.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.