After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688102 - jhbuild: Use new JHBUILD_LIBDIR environment variable.
jhbuild: Use new JHBUILD_LIBDIR environment variable.
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: unknown
unspecified
Other All
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-11 16:53 UTC by Carl-Anton Ingmarsson
Modified: 2013-02-09 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
jhbuild: Extract libdir from newly added JHBUILD_LIBDIR environment variable. (2.93 KB, patch)
2012-11-11 16:53 UTC, Carl-Anton Ingmarsson
committed Details | Review
jhbuild: Translate error messages. (2.59 KB, patch)
2012-11-11 16:53 UTC, Carl-Anton Ingmarsson
committed Details | Review

Description Carl-Anton Ingmarsson 2012-11-11 16:53:52 UTC
Also mark error strings for translation.
Comment 1 Carl-Anton Ingmarsson 2012-11-11 16:53:54 UTC
Created attachment 228701 [details] [review]
jhbuild: Extract libdir from newly added JHBUILD_LIBDIR environment variable.

This requires JHBuild from 2012-11-06 or later.
Comment 2 Carl-Anton Ingmarsson 2012-11-11 16:53:58 UTC
Created attachment 228702 [details] [review]
jhbuild: Translate error messages.
Comment 3 Sébastien Granjoux 2012-11-11 17:07:04 UTC
Isn't it better to keep the old code finding libdir to make it works with an older version of jhbuild?
Comment 4 Carl-Anton Ingmarsson 2012-11-11 17:21:45 UTC
I don't think that's necessary since it's recommended to install JHBuild from git and not from packages. Also anjuta 3.8 will not be released in a long time so the distro packaged JHBuild will most certainly be new enough by then.
Comment 5 Sébastien Granjoux 2012-11-11 18:54:33 UTC
(In reply to comment #4)
> I don't think that's necessary since it's recommended to install JHBuild from
> git and not from packages. Also anjuta 3.8 will not be released in a long time
> so the distro packaged JHBuild will most certainly be new enough by then.

Ok, it makes sense.

But I think I can wait a bit to commit this patch or do you need it?
Comment 6 Carl-Anton Ingmarsson 2012-11-11 19:18:41 UTC
No it can wait a bit. It's just to simplify the code.
Comment 7 Sébastien Granjoux 2013-02-09 13:32:32 UTC
Thanks for your patches, I have just committed them.