After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688039 - 'Remember Password' checkbox should default to unchecked
'Remember Password' checkbox should default to unchecked
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 694720 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-10 13:33 UTC by Ron Yorston
Modified: 2013-02-26 09:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The trivial patch I'm using (830 bytes, patch)
2012-11-14 09:44 UTC, Ron Yorston 		none Details | Review
Keep the state of the checkbox in GSettings (2.81 KB, patch)
2012-11-15 21:46 UTC, Ron Yorston 		committed Details | Review

Description Ron Yorston 2012-11-10 13:33:00 UTC 
When I plug in an encrypted USB disk I'm prompted for the password.  The dialog includes a 'Remember Password' checkbox which is checked by default.  Since I don't want the password to be remembered I have to remember to uncheck the box every time.  If I forget I have to fire up seahorse and make it forget the password.  This is inconvenient.

Having the box unchecked by default is less convenient for people who want the password to be remembered, but they only have to remember to check it once.  After that they can forget about it.
Comment 1 Ron Yorston 2012-11-14 09:44:54 UTC 
Created attachment 228948 [details] [review]
The trivial patch I'm using
Comment 2 Milan Bouchet-Valat 2012-11-14 11:00:27 UTC 
OTOH I can see how this could mean that some users would never check this box just because they usually follow the defaults. That may sound silly, but I know such users are not rare. Plus, GNOME's policy is that the default should really suit the majority.

So another option would be to remember the last state of the checkbox in GSettings. This way, we can keep the good default, but you only need to uncheck the box once...
Comment 3 Allan Day 2012-11-14 11:35:05 UTC 
(In reply to comment #2)
...
> So another option would be to remember the last state of the checkbox in
> GSettings. This way, we can keep the good default, but you only need to uncheck
> the box once...

Yep, that sounds like a better solution to me.
Comment 4 Ron Yorston 2012-11-15 21:46:45 UTC 
Created attachment 229100 [details] [review]
Keep the state of the checkbox in GSettings
Comment 5 Giovanni Campagna 2012-11-28 20:00:40 UTC 
Review of attachment 229100 [details] [review]:

Looks good to me.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:58:38 UTC 
Ron, do you have a git.gnome.org account or do you need someone to push?
Comment 7 Ron Yorston 2012-12-02 21:59:34 UTC 
I don't have a git account.
Comment 8 Giovanni Campagna 2012-12-02 22:03:30 UTC 
Ok, pushed!
Comment 9 Allan Day 2012-12-03 10:30:28 UTC 
Thanks Ron and Giovanni!
Comment 10 Milan Bouchet-Valat 2013-02-26 09:48:18 UTC 
*** Bug 694720 has been marked as a duplicate of this bug. ***