GNOME Bugzilla – Bug 688002
Easy access to font and font-size editor
Last modified: 2012-11-09 21:20:27 UTC
With this patch when no text is selected it allows to apply the font and/or font size change from the floating style editor.
What patch? :)
lol .. issue with sending it I guess. Anyway I've found a bug in it so I'm going to work more on that. I forgot to update the textoptions while modifying the styleeditor :) Looking at it and send a better patch.
The span based style editor is supposed to be independent of the text options. I haven't seen your patch, so consider this just a FYI.
Created attachment 228606 [details] [review] style editor This is the old patch. I guess it would be better to have a consistent behavior, for example when the style editor is updated, this updates should reflect the text toolbox and the gimp text editor. Right now this does happen and also create a kind of annoying bug. For example, if you change something in the style editor, font or size it changes it but if you go at the beginning of the text, it always read the text toolbox options making it to switch font. There's a reason to have it like that?
Yes, compatibility with old XCF files, and lack of time to make things proper. Your patch changes the whole text's properties when there is no selection. Instead, the right thing to do would be to set the properties of the text you will enter *after* you changed stuff, which is how the style GUI controls of text editors usually work. The toggle buttons for bold, italic etc. already behave like that. The options from the tool options that overlap with the floating editor should simply be the properties of the outmost span that covers all the text, which is non-trivial given we have to maintain compatibility with existing XCF files.
Created attachment 228608 [details] [review] Patch that does the right thing for the color toggle This is an example of what should happen, for the color button.
Hi, thanks for the example! Meaning of my patch was to avoid selecting all the text when you just want to change some properties without any editing. Sometimes you want to see the whole picture and later tweak details.
Actually, this is a duplicate, we should continue this in the older bug about the same topic. *** This bug has been marked as a duplicate of bug 631934 ***