After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687825 - weight-set in GtkCellRendererText not working
weight-set in GtkCellRendererText not working
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.24.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-11-07 07:33 UTC by Nick Schermer
Modified: 2013-02-03 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nick Schermer 2012-11-07 07:33:34 UTC
In Thunar there are 2 bugs related to weight-set not working.

The issue was that "weight-set" was set to FALSE, but the "weight" (not set in the GtkTreeStore) was still applied. Therefore the text was renderer in ExtraLight (the enum in the model was 0, probably clamped to 100). Changing the order of "weight-set" and "weight" fixed the problem.

http://git.xfce.org/xfce/thunar/commit/?id=bddf31b2cd54b2bbd589ec6a4c395a3aa88f9c50

Another problem (not resolved) is where the "weight" is set using g_object_set(), and enabling the value relies on "weight-set". See the code here:

http://git.xfce.org/xfce/thunar/tree/thunar/thunar-renamer-dialog.c#n440

If THUNAR_RENAMER_MODEL_COLUMN_CONFLICT is TRUE for the row, the text should become bold, but it doesn't. It works fine for foreground-set in this part of the code.
Comment 1 Matthias Clasen 2012-11-07 16:54:51 UTC
You don't have to set weight-set manually yourself. That is just not how the -set properties here are supposed to be used. weight-set gets set as a side-effect of setting weight.
Comment 2 Matthias Clasen 2012-11-07 16:55:46 UTC
In particular, you cannot set weight-set to FALSE to change the weight back to normal. Just set the weight property itself back.
Comment 3 Nick Schermer 2012-11-07 17:05:35 UTC
Would be nice if that is documented then (also for the other properties that use the PangoFontMask internally). Because it works with {background,foreground}-set; although maybe not intentionally.