After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687753 - gsf(1) now has a gio dependency
gsf(1) now has a gio dependency
Status: RESOLVED FIXED
Product: libgsf
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 687175 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-06 13:17 UTC by Allison Karlitskaya (desrt)
Modified: 2012-11-17 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: hard-depend on libgio (3.51 KB, patch)
2012-11-06 13:25 UTC, Allison Karlitskaya (desrt)
none Details | Review
tools/: Add -lgio to LIBS for gsf tool (789 bytes, patch)
2012-11-08 16:33 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2012-11-06 13:17:15 UTC
make[2]: Entering directory `/home/desrt/code/libgsf/tools'
  CCLD   gsf
/usr/bin/ld: gsf.o: undefined reference to symbol 'g_file_new_for_path'
/usr/bin/ld: note: 'g_file_new_for_path' is defined in DSO /home/desrt/local/lib/libgio-2.0.so.0 so try adding it to the linker command line
/home/desrt/local/lib/libgio-2.0.so.0: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[2]: *** [gsf] Error 1



It looks like gsf tries to conditionally enable support for GIO.  The tool now has a hard dependency on it, so it's probably time to simplify that code.
Comment 1 Allison Karlitskaya (desrt) 2012-11-06 13:25:59 UTC
Created attachment 228244 [details] [review]
build: hard-depend on libgio

It's already in the same package as libglib and libgobject (on which we
already have hard depends) and we're using it from the commandline tool
unconditionally (which means that the build breaks if you try to disable
the support).
Comment 2 Allison Karlitskaya (desrt) 2012-11-08 16:33:16 UTC
Created attachment 228488 [details] [review]
tools/: Add -lgio to LIBS for gsf tool
Comment 3 Allison Karlitskaya (desrt) 2012-11-08 16:35:15 UTC
Comment on attachment 228488 [details] [review]
tools/: Add -lgio to LIBS for gsf tool

Attachment 228488 [details] pushed as 1302f9c - tools/: Add -lgio to LIBS for gsf tool

I've pushed this (more minimal) patch for the time being in order to
unbreak jhbuild.  Sorry for that.

Please feel free to revert it if you had a different solution in mind
(such as the more complicated patch that's attached here as well).
Comment 4 Morten Welinder 2012-11-13 02:30:55 UTC
Commit looks fine.  I will try to get a release out soonish -- I have
been wanting to do that anyway.

Sorry about the late response -- Sandy cut power and internet here.
Comment 5 Morten Welinder 2012-11-13 15:56:42 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 6 Morten Welinder 2012-11-17 15:57:54 UTC
*** Bug 687175 has been marked as a duplicate of this bug. ***