After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687744 - Use GtkSeachEntry instead of EphySearchEntry
Use GtkSeachEntry instead of EphySearchEntry
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-06 11:20 UTC by Bastien Nocera
Modified: 2012-12-10 07:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use GtkSeachEntry instead of EphySearchEntry (4.30 KB, patch)
2012-11-06 11:20 UTC, Bastien Nocera
committed Details | Review
lib: Remove unused EphySearchEntry widget (14.45 KB, patch)
2012-11-06 11:20 UTC, Bastien Nocera
committed Details | Review
Remove redundant search labels (2.62 KB, patch)
2012-12-09 13:27 UTC, William Jon McCann
committed Details | Review

Description Bastien Nocera 2012-11-06 11:20:28 UTC
.
Comment 1 Bastien Nocera 2012-11-06 11:20:30 UTC
Created attachment 228236 [details] [review]
Use GtkSeachEntry instead of EphySearchEntry

Does pretty the same thing, without the cut'n'paste.
Comment 2 Bastien Nocera 2012-11-06 11:20:52 UTC
Created attachment 228237 [details] [review]
lib: Remove unused EphySearchEntry widget
Comment 3 Xan Lopez 2012-12-09 11:16:58 UTC
Review of attachment 228236 [details] [review]:

OK.
Comment 4 Xan Lopez 2012-12-09 11:17:33 UTC
Review of attachment 228237 [details] [review]:

Woot.
Comment 5 William Jon McCann 2012-12-09 13:27:18 UTC
Created attachment 231064 [details] [review]
Remove redundant search labels
Comment 6 Xan Lopez 2012-12-09 13:38:57 UTC
Review of attachment 231064 [details] [review]:

OK.
Comment 7 Bastien Nocera 2012-12-10 07:55:42 UTC
Attachment 228236 [details] pushed as 52b8772 - Use GtkSeachEntry instead of EphySearchEntry
Attachment 228237 [details] pushed as 4666852 - lib: Remove unused EphySearchEntry widget
Attachment 231064 [details] pushed as 56d6c08 - Remove redundant search labels