After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687718 - use of git submodules is broken
use of git submodules is broken
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-06 03:52 UTC by Allison Karlitskaya (desrt)
Modified: 2013-03-18 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allison Karlitskaya (desrt) 2012-11-06 03:52:18 UTC 
gnome-font-viewer uses a git submodule for libgd.

Ideally, it should just stop doing that entirely.  There are better ways to deal with this sort of situation (including subtree merges) that don't require network at ./autogen.sh time.

Failing that, though, it should not specify the submodule using a relative path as it does (../libgd).  git is distributed and there is no guarantee that there will exist a libgd in the same location as I cloned from.

In particular: this fails when using jhbuild with the dvcs mirror option.
Comment 1 Cosimo Cecchi 2012-11-08 19:07:26 UTC 
Thanks for the report, I now changed this not to use a relative path in git master.
Comment 2 Zeeshan Ali 2013-03-01 12:52:24 UTC 
(In reply to comment #1)
> Thanks for the report, I now changed this not to use a relative path in git
> master.
 
Which commit(s) fixed this in  gnome-font-viewer so I can copy&paste for bug#687961 ? :)
Comment 3 Marc-Andre Lureau 2013-03-18 12:58:25 UTC 
the argument about git mirrors is bogus: If you have a mirror, you don't want to partially mirror your repositories, you end up with something mirrored here but not really... 

The relative path is superior, because it keeps the same access method as the one used for the main repository (local vs git vs auth ssh vs..), and actually can be mirrored the proper way.
Comment 4 Christophe Fergeau 2013-03-18 13:17:58 UTC 
Marc-André, think about an external contributor forking gnome-boxes to gitorious. They will needlessly have to import any git submodules there if ../gd is used.
Comment 5 Marc-Andre Lureau 2013-03-18 13:24:58 UTC 
(In reply to comment #4)
> Marc-André, think about an external contributor forking gnome-boxes to
> gitorious. They will needlessly have to import any git submodules there if
> ../gd is used.

is it a mirror or is it just a branch for pulling? If it's a mirror, they should mirror all, not just partially. If someone want to clone boxes, he should clone from the source.