After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687708 - prevent lock in initial-setup mode
prevent lock in initial-setup mode
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-06 02:04 UTC by Matthias Clasen
Modified: 2012-11-11 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: fix code to detect missing unlock dialog (1.50 KB, patch)
2012-11-06 22:45 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2012-11-06 02:04:17 UTC 
1. boot into initial setup
2. leave your computer for a while
3. come back to find the lock screen
4. lift the shield
5. wall of gray :-(
Comment 1 Giovanni Campagna 2012-11-06 22:45:05 UTC 
Created attachment 228320 [details] [review]
ScreenShield: fix code to detect missing unlock dialog

If the session mode has no locking support, screenshield had code to
unlock automatically, but it did so by checking the return value of
the constructor, instead of checking if the constructor was actually
callable, so it would get a TypeError before reaching the check.

Try again with this one. It might fail again, as this code path
apparently wasn't tested much during 3.6. In particular I'm afraid
that .unlock() might leave the shell in an interesting state, if
called at the wrong time (such as after a dragBegin)
Comment 2 Matthias Clasen 2012-11-08 02:59:43 UTC 
Thanks, it works fine in quick testing here.
Comment 3 Matthias Clasen 2012-11-10 22:17:25 UTC 
Can we get this merged for 3.6.2 ?
Comment 4 Giovanni Campagna 2012-11-11 17:53:48 UTC 
(In reply to comment #3)
> Can we get this merged for 3.6.2 ?

It is still waiting for a review.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-11-11 17:58:40 UTC 
Review of attachment 228320 [details] [review]:

This makes sense to me.
Comment 6 Giovanni Campagna 2012-11-11 18:19:13 UTC 
Attachment 228320 [details] pushed as 271508c - ScreenShield: fix code to detect missing unlock dialog