After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687672 - Stop depending on Metacity!
Stop depending on Metacity!
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-05 17:35 UTC by Florian Müllner
Modified: 2012-11-13 15:47 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
keybindings: Import keybinding files from Metacity (7.94 KB, patch)
2012-11-05 17:35 UTC, Florian Müllner
committed Details | Review
po: Import translations from Metacity (450.34 KB, patch)
2012-11-05 17:35 UTC, Florian Müllner
committed Details | Review
main: Stop using Metacity's keybinding files (963 bytes, patch)
2012-11-05 17:36 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-11-05 17:35:32 UTC
While we already compile/run without metacity installed, we still rely on metacity's keybinding files for common keybindings - as a result, the shortcuts panel in System Settings ends up empty and sad if metacity is not around.

There are two obvious possibilities to remove that dependency - either keep the keybinding files in a shared location, or duplicate them in the mutter module. I went with the latter, as that will allow us to come up with meaningful descriptions rather than forcing a common one (e.g. "Show the activities overview" does not make any sense at all in fallback mode), and also as there's no existing module that's a good fit for those files.
Comment 1 Florian Müllner 2012-11-05 17:35:38 UTC
Created attachment 228161 [details] [review]
keybindings: Import keybinding files from Metacity

Fallback mode is going away, so we should stop depending on Metacity
for keybinding files for common bindings.
Comment 2 Florian Müllner 2012-11-05 17:35:46 UTC
Created attachment 228162 [details] [review]
po: Import translations from Metacity

To save translators some work, import existing translations for the
newly added keybinding files.
Comment 3 Florian Müllner 2012-11-05 17:36:50 UTC
Created attachment 228163 [details] [review]
main: Stop using Metacity's keybinding files

The descriptions for keybindings shared with Metacity are now
duplicated in Mutter, so only use the latter to avoid duplicate
entries in System Settings.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-11-05 17:49:17 UTC
Review of attachment 228161 [details] [review]:

Sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-11-05 17:49:21 UTC
Review of attachment 228163 [details] [review]:

Sure.
Comment 6 Florian Müllner 2012-11-13 15:46:39 UTC
Attachment 228161 [details] pushed as bdf47ae - keybindings: Import keybinding files from Metacity
Attachment 228162 [details] pushed as 395fbef - po: Import translations from Metacity
Comment 7 Florian Müllner 2012-11-13 15:47:26 UTC
Attachment 228163 [details] pushed as 2407a0c - main: Stop using Metacity's keybinding files