After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687657 - rtpsession: Demux RTCP buffers from the RTP stream
rtpsession: Demux RTCP buffers from the RTP stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-05 15:30 UTC by Olivier Crête
Modified: 2013-09-18 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpsession: Demux RTCP buffers from the RTP stream (3.39 KB, patch)
2012-11-05 15:30 UTC, Olivier Crête 		none Details | Review

Description Olivier Crête 2012-11-05 15:30:12 UTC 
Allow RTCP buffers to arrive inside the RTP stream and demux them inside rtpsession. It's so trivial to do it there that there is no point doing a separate element. This makes it easier to support the a=rtcp-mux (ie RFC 5761).
Comment 1 Olivier Crête 2012-11-05 15:30:19 UTC 
Created attachment 228128 [details] [review]
rtpsession: Demux RTCP buffers from the RTP stream

If there are RTCP buffers in the RTP stream, process them as
RTCP. This way, we want receive streams following RFC 5761
Comment 2 Olivier Crête 2013-04-08 22:33:48 UTC 
Ping? Any opinion on this? I'd also put the same thing in srtpdec.
Comment 3 Wim Taymans 2013-09-13 14:29:19 UTC 
Sorry for delay, I didn't want the additional check for the common RTP path. Updated patch relies on the RTP map code to reject possible RTCP packets. If an RTP packet is declared invalid, we attempt to decode the packet as RTCP.


commit b9ceafe5af016df012fab524418ae6b506a1f8a4
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Fri Sep 13 16:25:49 2013 +0200

    rtpsession: Demux RTCP buffers from the RTP stream
    
    If there are RTCP buffers in the RTP stream, process them as
    RTCP. This way, we want receive streams following RFC 5761
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687657