After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687656 - "Not Listed?" - "Sign In" should read as "Next"
"Not Listed?" - "Sign In" should read as "Next"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-05 15:26 UTC by Allan Day
Modified: 2012-11-07 00:41 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
unlockDialog: better confirmation button label (2.22 KB, patch)
2012-11-06 23:17 UTC, Stéphane Démurget
committed Details | Review

Description Allan Day 2012-11-05 15:26:59 UTC
If I click on "Not listed?" in the login screen, I come to a username field with two buttons: "Cancel" and "Sign In".

Clicking on "Sign In" doesn't actually sign me in though - it takes me to the login entry. It would be better to rename "Sign In" to "Next" for the username stage, therefore.

The blue button should still read "Sign In" when the password field is displayed.
Comment 1 Stéphane Démurget 2012-11-06 23:17:54 UTC
Created attachment 228321 [details] [review]
unlockDialog: better confirmation button label

If I click on "Not listed?" in the login screen, I come to a username
field with two buttons: "Cancel" and "Sign In".

Clicking on "Sign In" doesn't actually sign me in though - it takes me
to the login entry. It would be better to rename "Sign In" to "Next" for
the username stage, therefore.

Gdm emit a signal to ask a question or a secret, but we can not know if
this is the last authentication question, hence we only use "Sign In"
for secret questions which improve the situation a lot.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-06 23:34:38 UTC
Review of attachment 228321 [details] [review]:

This is ugly, but I think it will work for now. In most workflows, the secret is the last thing issued.

::: js/gdm/loginDialog.js
@@ +915,3 @@
                                          hold.release();
                                      }),
+                             label: forSecret ? C_('button', 'Sign In') : _('Next'),

These need to be ""s.
Comment 3 Stéphane Démurget 2012-11-07 00:28:20 UTC
Comment on attachment 228321 [details] [review]
unlockDialog: better confirmation button label

Attachment 228321 [details] pushed as 1228db6 - unlockDialog: better confirmation button label