After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687652 - cogl: Don't use cogl_xlib_set_diplay()
cogl: Don't use cogl_xlib_set_diplay()
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-05 14:49 UTC by Damien Lespiau
Modified: 2013-02-20 23:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cogl: Don't use cogl_xlib_set_diplay() (1.90 KB, patch)
2012-11-05 14:49 UTC, Damien Lespiau 		committed Details | Review

Description Damien Lespiau 2012-11-05 14:49:24 UTC 
This function is deprecated and has been replaced by set_display() on
the renderer. This is done in the get_renderer() vfunc of both the x11
and gdk backends already.

Actually cogl_xlib_set_diplay() is now a no-op and can be safely removed.
Comment 1 Damien Lespiau 2012-11-05 14:49:26 UTC 
Created attachment 228122 [details] [review]
cogl: Don't use cogl_xlib_set_diplay()
Comment 2 Emmanuele Bassi (:ebassi) 2012-11-05 15:13:36 UTC 
Review of attachment 228122 [details] [review]:

does this happen with Cogl 1.10 as well, or only with 1.12? if the change has been introduced in Cogl 1.12, then you'll have to bump the dependency inside configure.ac as well (possibly as a separate commit).
Comment 3 Damien Lespiau 2012-11-05 17:51:43 UTC 
What I've written is true for both 1.10 and 1.12. Obviously the symbol is still there in both versions but is likely to be removed for 2.0.

The patch is purely removal of lines, there is no new call to a new thing, so no bump needed?
Comment 4 Emmanuele Bassi (:ebassi) 2013-02-20 23:35:35 UTC 
Attachment 228122 [details] pushed as 3e479a3 - cogl: Don't use cogl_xlib_set_diplay()