GNOME Bugzilla – Bug 687651
Organize dialog is hard to understand
Last modified: 2013-05-28 09:11:28 UTC
If I select a document and click on the "organize" button, I get an "Organize" dialog (see attached screenshot). It is non-obviousness what this dialog is for or how I am supposed to use it. There is an "Add" button, but what am I adding? Clicking on it doesn't hold any clues either. I can provide mockups for this, if that would be helpful.
Created attachment 228120 [details] screenshot
*** Bug 687878 has been marked as a duplicate of this bug. ***
Created attachment 229362 [details] mockup See the attached mockup for an idea about how to do the dialog.
I like that. But you're still cheating by having some predefined collections in the mockup :) It is better than what we have, but having at least one collection pre-defined ('Important'?) would make the dialog more likely to be understood initially. But then we might need to make it just as easy to remove a collection from here as well.
Created attachment 229503 [details] another mockup jimmac, allan: what about something like this?
(In reply to comment #5) > Created an attachment (id=229503) [details] > another mockup > > jimmac, allan: what about something like this? I would like that - seems cleaner than my mockup.
Allan, Andreas: thanks for the mockups. This dialog is probably the most awful part of Documents and I really want to make it better. I really like the "no collections defined" initial state in Andreas' mockup. However, having the "Create new collection" in the view always at the bottom of the list sounds a little problematic to me: if you have a number of collections, you would need to scroll down the whole list before adding a new one. How about keeping it at the top of the list instead? Alternatively, a separate control like in Allan's version could be a good choice.
Keeping it at the top would work.
Created attachment 245051 [details] [review] selections: Revamp the OrganizeCollectionView as per new designs - Is it possible to avoid having to double click to start typing in the name of the new collection? - I don't know why "valign: Gtk.Align.CENTER" is not working for this._msgGrid with GTK+ master. I have worked around it using margin_top. - Isn't the dialog too wide? Should it be resizable?
Created attachment 245055 [details] With pre-existing collections
Created attachment 245056 [details] Without any collections
(In reply to comment #11) > Created an attachment (id=245056) [details] > Without any collections Crap, that icon looks all wrong there. Let me try another one.
Created attachment 245147 [details] new icon lets see if this works better
(In reply to comment #10) > Created an attachment (id=245055) [details] > With pre-existing collections The new collection don't look like a proper input control. Could we add rows to this?
Created attachment 245219 [details] [review] selections: Revamp the OrganizeCollectionView as per new designs
Created attachment 245221 [details] With pre-existing collections
Created attachment 245222 [details] Without any collections
Much better! Not super-happy about the text yet, so ideally a documentation writer should take a look at it.
Shaun McCance suggested these string on IRC: "No defined collections yet. Enter a new collection name above." or "You don't have any collections yet. Enter a new collection name above." or "To create a new collection, enter the name of the collection above." I think I like number 2 best.
Review of attachment 245219 [details] [review]: Thanks for the patch! Pending the comments on the wording used in the dialog, this looks mostly good to me. I only have a couple of comments below. ::: src/selections.js @@ +467,3 @@ + + // show the overlay only if there aren't any collections in the model + margin_top: 64 }); You could use iter_n_children() instead of checking the length manually. @@ +475,3 @@ + + // force the editable row to be unselected + this._msgGrid.add(this._icon); Can the same be achieved more cleanly by setting the selection mode to NONE?
(In reply to comment #19) > Shaun McCance suggested these string on IRC: > "No defined collections yet. Enter a new collection name above." > or > "You don't have any collections yet. Enter a new collection name above." > or > "To create a new collection, enter the name of the collection above." > > I think I like number 2 best. Changed the string to number 2: "You don't have any collections yet. Enter a new collection name above."
(In reply to comment #20) > Review of attachment 245219 [details] [review]: > > Thanks for the patch! Pending the comments on the wording used in the dialog, > this looks mostly good to me. I only have a couple of comments below. Thanks for the review. > ::: src/selections.js > @@ +467,3 @@ > + > + // show the overlay only if there aren't any collections in the model > + margin_top: 64 }); > > You could use iter_n_children() instead of checking the length manually. Done. > @@ +475,3 @@ > + > + // force the editable row to be unselected > + this._msgGrid.add(this._icon); > > Can the same be achieved more cleanly by setting the selection mode to NONE? I tried using NONE, but it prevents you from entering the name of a new collection too. SINGLE and BROWSE did not work out either because the editable row kept getting selected.
Created attachment 245383 [details] [review] selections: Revamp the OrganizeCollectionView as per new designs
Review of attachment 245383 [details] [review]: Looks good to me, thanks!