After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687651 - Organize dialog is hard to understand
Organize dialog is hard to understand
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 687878 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-05 14:38 UTC by Allan Day
Modified: 2013-05-28 09:11 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
screenshot (29.61 KB, image/png)
2012-11-05 14:42 UTC, Allan Day
  Details
mockup (16.52 KB, image/png)
2012-11-19 10:47 UTC, Allan Day
  Details
another mockup (52.48 KB, image/png)
2012-11-20 20:15 UTC, Andreas Nilsson
  Details
selections: Revamp the OrganizeCollectionView as per new designs (16.34 KB, patch)
2013-05-22 15:49 UTC, Debarshi Ray
none Details | Review
With pre-existing collections (263.29 KB, image/png)
2013-05-22 15:58 UTC, Debarshi Ray
  Details
Without any collections (276.58 KB, image/png)
2013-05-22 15:59 UTC, Debarshi Ray
  Details
new icon (686 bytes, image/png)
2013-05-23 15:08 UTC, Andreas Nilsson
  Details
selections: Revamp the OrganizeCollectionView as per new designs (17.42 KB, patch)
2013-05-24 10:07 UTC, Debarshi Ray
reviewed Details | Review
With pre-existing collections (257.42 KB, image/png)
2013-05-24 10:08 UTC, Debarshi Ray
  Details
Without any collections (283.77 KB, image/png)
2013-05-24 10:09 UTC, Debarshi Ray
  Details
selections: Revamp the OrganizeCollectionView as per new designs (17.39 KB, patch)
2013-05-27 12:35 UTC, Debarshi Ray
committed Details | Review

Description Allan Day 2012-11-05 14:38:41 UTC
If I select a document and click on the "organize" button, I get an "Organize" dialog (see attached screenshot). It is non-obviousness what this dialog is for or how I am supposed to use it. There is an "Add" button, but what am I adding? Clicking on it doesn't hold any clues either.

I can provide mockups for this, if that would be helpful.
Comment 1 Allan Day 2012-11-05 14:42:52 UTC
Created attachment 228120 [details]
screenshot
Comment 2 Cosimo Cecchi 2012-11-07 20:24:22 UTC
*** Bug 687878 has been marked as a duplicate of this bug. ***
Comment 3 Allan Day 2012-11-19 10:47:28 UTC
Created attachment 229362 [details]
mockup

See the attached mockup for an idea about how to do the dialog.
Comment 4 Jakub Steiner 2012-11-19 13:00:51 UTC
I like that. But you're still cheating by having some predefined collections in the mockup :) 

It is better than what we have, but having at least one collection pre-defined ('Important'?) would make the dialog more likely to be understood initially. But then we might need to make it just as easy to remove a collection from here as well.
Comment 5 Andreas Nilsson 2012-11-20 20:15:19 UTC
Created attachment 229503 [details]
another mockup

jimmac, allan: what about something like this?
Comment 6 Allan Day 2012-11-20 20:29:33 UTC
(In reply to comment #5)
> Created an attachment (id=229503) [details]
> another mockup
> 
> jimmac, allan: what about something like this?

I would like that - seems cleaner than my mockup.
Comment 7 Cosimo Cecchi 2012-11-20 21:58:22 UTC
Allan, Andreas: thanks for the mockups. This dialog is probably the most awful part of Documents and I really want to make it better.

I really like the "no collections defined" initial state in Andreas' mockup. However, having the "Create new collection" in the view always at the bottom of the list sounds a little problematic to me: if you have a number of collections, you would need to scroll down the whole list before adding a new one. How about keeping it at the top of the list instead? Alternatively, a separate control like in Allan's version could be a good choice.
Comment 8 Andreas Nilsson 2012-11-21 15:18:04 UTC
Keeping it at the top would work.
Comment 9 Debarshi Ray 2013-05-22 15:49:49 UTC
Created attachment 245051 [details] [review]
selections: Revamp the OrganizeCollectionView as per new designs

- Is it possible to avoid having to double click to start typing in the name of the new collection?

- I don't know why "valign: Gtk.Align.CENTER" is not working for this._msgGrid with GTK+ master. I have worked around it using margin_top.

- Isn't the dialog too wide? Should it be resizable?
Comment 10 Debarshi Ray 2013-05-22 15:58:06 UTC
Created attachment 245055 [details]
With pre-existing collections
Comment 11 Debarshi Ray 2013-05-22 15:59:07 UTC
Created attachment 245056 [details]
Without any collections
Comment 12 Andreas Nilsson 2013-05-23 14:57:52 UTC
(In reply to comment #11)
> Created an attachment (id=245056) [details]
> Without any collections

Crap, that icon looks all wrong there. Let me try another one.
Comment 13 Andreas Nilsson 2013-05-23 15:08:27 UTC
Created attachment 245147 [details]
new icon

lets see if this works better
Comment 14 Andreas Nilsson 2013-05-23 15:13:30 UTC
(In reply to comment #10)
> Created an attachment (id=245055) [details]
> With pre-existing collections

The new collection don't look like a proper input control. Could we add rows to this?
Comment 15 Debarshi Ray 2013-05-24 10:07:28 UTC
Created attachment 245219 [details] [review]
selections: Revamp the OrganizeCollectionView as per new designs
Comment 16 Debarshi Ray 2013-05-24 10:08:18 UTC
Created attachment 245221 [details]
With pre-existing collections
Comment 17 Debarshi Ray 2013-05-24 10:09:42 UTC
Created attachment 245222 [details]
Without any collections
Comment 18 Andreas Nilsson 2013-05-24 12:37:36 UTC
Much better!
Not super-happy about the text yet, so ideally a documentation writer should take a look at it.
Comment 19 Andreas Nilsson 2013-05-24 15:24:44 UTC
Shaun McCance suggested these string on IRC:
"No defined collections yet. Enter a new collection name above."
or
"You don't have any collections yet. Enter a new collection name above."
or
"To create a new collection, enter the name of the collection above."

I think I like number 2 best.
Comment 20 Cosimo Cecchi 2013-05-25 01:08:54 UTC
Review of attachment 245219 [details] [review]:

Thanks for the patch! Pending the comments on the wording used in the dialog, this looks mostly good to me. I only have a couple of comments below.

::: src/selections.js
@@ +467,3 @@
+
+        // show the overlay only if there aren't any collections in the model
+                                       margin_top: 64 });

You could use iter_n_children() instead of checking the length manually.

@@ +475,3 @@
+
+        // force the editable row to be unselected
+        this._msgGrid.add(this._icon);

Can the same be achieved more cleanly by setting the selection mode to NONE?
Comment 21 Debarshi Ray 2013-05-27 12:32:18 UTC
(In reply to comment #19)
> Shaun McCance suggested these string on IRC:
> "No defined collections yet. Enter a new collection name above."
> or
> "You don't have any collections yet. Enter a new collection name above."
> or
> "To create a new collection, enter the name of the collection above."
> 
> I think I like number 2 best.

Changed the string to number 2:
"You don't have any collections yet. Enter a new collection name above."
Comment 22 Debarshi Ray 2013-05-27 12:34:07 UTC
(In reply to comment #20)
> Review of attachment 245219 [details] [review]:
> 
> Thanks for the patch! Pending the comments on the wording used in the dialog,
> this looks mostly good to me. I only have a couple of comments below.

Thanks for the review.
 
> ::: src/selections.js
> @@ +467,3 @@
> +
> +        // show the overlay only if there aren't any collections in the model
> +                                       margin_top: 64 });
> 
> You could use iter_n_children() instead of checking the length manually.

Done.

> @@ +475,3 @@
> +
> +        // force the editable row to be unselected
> +        this._msgGrid.add(this._icon);
> 
> Can the same be achieved more cleanly by setting the selection mode to NONE?

I tried using NONE, but it prevents you from entering the name of a new collection too. SINGLE and BROWSE did not work out either because the editable row kept getting selected.
Comment 23 Debarshi Ray 2013-05-27 12:35:10 UTC
Created attachment 245383 [details] [review]
selections: Revamp the OrganizeCollectionView as per new designs
Comment 24 Cosimo Cecchi 2013-05-28 02:39:12 UTC
Review of attachment 245383 [details] [review]:

Looks good to me, thanks!