GNOME Bugzilla – Bug 687601
uninstall: support automatically created modules
Last modified: 2013-04-01 00:35:21 UTC
jhbuild buildone supports on-the-fly module creation, once installed these modules can not be removed because jhbuild uninstall does not support on-the-fly creation. Fix this copying the solution in buildone. This should be completely safe and inocuous. On-the-fly modules behave just like regular moduleset ones: their manifest is used if it exists, and their registry is taken care of in the packagedb.
Created attachment 228063 [details] [review] uninstall: support automatically created modules "jhbuild buildone" creates automatic modules for arguments that are not declared modules in the moduleset. Once installed, these can not be uninstalled because "jhbuild uninstall" demands modules to in the moduleset file, even when manifest files are available for the automatically created ones. Fix uninstall to support on-the-fly creation of modules. This works just like with moduleset modules.
Ping
Thank you for the patch. Unreviewed patches aren't fun - I'll review soon.
Sorry. I haven't forgotten. A busy time of year.
Thanks for the comment Craig, no worries! :-)
Review of attachment 228063 [details] [review]: Thank you for the patch, and I'm sorry for the delay. If I attempted to uninstall a package that isn't installed I get: # jhbuild uninstall dsadsadasdasd I: module "dsadsadasdasd" does not exist, created automatically using repository "git.gnome.org" W: Module 'dsadsadasdasd' is not installed I should only get: # jhbuild uninstall dsadsadasdasd W: Module 'dsadsadasdasd' is not installed Otherwise the patch works well. ::: jhbuild/commands/uninstall.py @@ +46,3 @@ + except KeyError: + if not default_repo: + raise FatalError(_('unknown module %s and no default repository to create automatic module') % modname) This message is misleading. We are uninstalling here, not creating.
Created attachment 232790 [details] [review] uninstall: support automatically created modules "jhbuild buildone" creates automatic modules for arguments that are not declared modules in the moduleset. Once installed, these can not be uninstalled because "jhbuild uninstall" demands modules to in the moduleset file, even when manifest files are available for the automatically created ones. Fix uninstall to support on-the-fly creation of modules. This works just like with moduleset modules.
Comment on attachment 232790 [details] [review] uninstall: support automatically created modules Thank you for the patch. Committed. Sorry for the delay. https://git.gnome.org/browse/jhbuild/commit/?id=b27cebe88efb5347ce5744765650fc4eec35f46d