After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687543 - application: Add F1 accelerator to show help
application: Add F1 accelerator to show help
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-04 02:58 UTC by Jeremy Bicha
Modified: 2012-11-05 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application: Add F1 accelerator to show help (917 bytes, patch)
2012-11-04 02:58 UTC, Jeremy Bicha 		none Details | Review
application: Add F1 accelerator to show help & Ctrl+P to print (1.36 KB, patch)
2012-11-04 03:10 UTC, Jeremy Bicha 		none Details | Review
application: Mention Ctrl+P accelerator in gear menu (915 bytes, patch)
2012-11-04 03:17 UTC, Jeremy Bicha 		none Details | Review
application: Add F1 accelerator to show help & Ctrl+P to print (1.85 KB, patch)
2012-11-04 03:18 UTC, Jeremy Bicha 		committed Details | Review
0001-application-use-real-ellipsis-for-Print.patch (1.00 KB, patch)
2012-11-04 03:24 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2012-11-04 02:58:30 UTC 
Standard keyboard shortcut
Comment 1 Jeremy Bicha 2012-11-04 02:58:32 UTC 
Created attachment 228000 [details] [review]
application: Add F1 accelerator to show help
Comment 2 Jeremy Bicha 2012-11-04 03:10:47 UTC 
Created attachment 228001 [details] [review]
application: Add F1 accelerator to show help & Ctrl+P to print
Comment 3 Jeremy Bicha 2012-11-04 03:17:09 UTC 
Created attachment 228002 [details] [review]
application: Mention Ctrl+P accelerator in gear menu
Comment 4 Jeremy Bicha 2012-11-04 03:18:38 UTC 
Created attachment 228003 [details] [review]
application: Add F1 accelerator to show help & Ctrl+P to print
Comment 5 Jeremy Bicha 2012-11-04 03:24:49 UTC 
Created attachment 228004 [details] [review]
0001-application-use-real-ellipsis-for-Print.patch

Here's a related patch I separated since we don't want to commit this to the 3.6 branch.
Comment 6 Cosimo Cecchi 2012-11-05 14:39:51 UTC 
Review of attachment 228003 [details] [review]:

Looks good, thanks!
Comment 7 Cosimo Cecchi 2012-11-05 14:40:11 UTC 
Review of attachment 228004 [details] [review]:

Sure, looks good.
Comment 8 Jeremy Bicha 2012-11-05 14:45:56 UTC 
Comment on attachment 228003 [details] [review]
application: Add F1 accelerator to show help & Ctrl+P to print

Attachment 228003 [details] pushed as e2ac207 - application: Add F1 accelerator to show help & Ctrl+P to print